diff options
| author | Jarkko Hietaniemi <jhi@iki.fi> | 2009-06-14 12:53:22 -0400 |
|---|---|---|
| committer | Craig A. Berry <craigberry@mac.com> | 2009-06-14 19:02:15 -0500 |
| commit | c6757210fa44035178e0a2501e1022995a42b70d (patch) | |
| tree | d4b7449976d9238af4f1b6ab2619a03ba96e5800 /perlio.c | |
| parent | 423174046424f87a68e7227cd8015f1926fede2d (diff) | |
| download | perl-c6757210fa44035178e0a2501e1022995a42b70d.tar.gz | |
The attached patch to perlio.c fixes the problem of errno getting set.
While I am firmly in the school of "do not look at $! except immediately
after a failure", I also agree that spuriously setting it is messy. But
there is just no way of knowing where your errno might have been.
The problem was that PerlIO_fast_gets() (and other nearby similar
capability-checking PerlIO routines) set the errno (and it was being
called a lot, from sv_gets()). I think setting the errno here was
a mistake: checking for "can has FOO" should not set external state,
such as the errno. The patch removes that errno trashing from all those
routines.
Diffstat (limited to 'perlio.c')
| -rw-r--r-- | perlio.c | 12 |
1 files changed, 0 insertions, 12 deletions
@@ -1773,10 +1773,7 @@ PerlIO_has_base(PerlIO *f) if (tab) return (tab->Get_base != NULL); - SETERRNO(EINVAL, LIB_INVARG); } - else - SETERRNO(EBADF, SS_IVCHAN); return 0; } @@ -1790,11 +1787,8 @@ PerlIO_fast_gets(PerlIO *f) if (tab) return (tab->Set_ptrcnt != NULL); - SETERRNO(EINVAL, LIB_INVARG); } } - else - SETERRNO(EBADF, SS_IVCHAN); return 0; } @@ -1807,10 +1801,7 @@ PerlIO_has_cntptr(PerlIO *f) if (tab) return (tab->Get_ptr != NULL && tab->Get_cnt != NULL); - SETERRNO(EINVAL, LIB_INVARG); } - else - SETERRNO(EBADF, SS_IVCHAN); return 0; } @@ -1823,10 +1814,7 @@ PerlIO_canset_cnt(PerlIO *f) if (tab) return (tab->Set_ptrcnt != NULL); - SETERRNO(EINVAL, LIB_INVARG); } - else - SETERRNO(EBADF, SS_IVCHAN); return 0; } |