diff options
| author | David Mitchell <davem@iabyn.com> | 2018-12-26 12:58:06 +0000 |
|---|---|---|
| committer | David Mitchell <davem@iabyn.com> | 2019-02-19 13:28:12 +0000 |
| commit | 999d65ede909a162fb0accd370ffdf1411e94d5e (patch) | |
| tree | f729bec46a0a745f8f178d03aae29602da4aa014 /perlvars.h | |
| parent | 4ef8bdf9dc2018cb385cf00d11e2e74f0491f8e9 (diff) | |
| download | perl-999d65ede909a162fb0accd370ffdf1411e94d5e.tar.gz | |
foo_cloexec() under PERL_GLOBAL_STRUCT_PRIVATE
Fix the various Perl_PerlSock_dup2_cloexec() type functions so that
t/porting/liberl.a passes under -DPERL_GLOBAL_STRUCT_PRIVATE builds.
In these builds it is forbidden to have any static variables, but each
of these functions (via convoluted macros) has a static var called
'strategy' which records, for each function, whether a run-time probe
has been done to determine the best way of achieving close-exec
functionality, and the result.
Replace them all with 'global' vars: PL_strategy_dup2 etc.
NB these vars aren't thread-safe but it doesn't really matter, as the
worst that can happen is for a redundant probe or two to be done before
a suitable "don't probe any more" value is written to the var and seen
by all the threads.
Diffstat (limited to 'perlvars.h')
| -rw-r--r-- | perlvars.h | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/perlvars.h b/perlvars.h index 51c939e128..d8139c068d 100644 --- a/perlvars.h +++ b/perlvars.h @@ -321,3 +321,19 @@ PERLVAR(G, user_prop_mutex, perl_mutex) /* Mutex for manipulating /* Everything that folds to a given character, for case insensitivity regex * matching */ PERLVAR(G, utf8_foldclosures, SV *) + +/* these record the best way to to perform certain IO operations while + * atomically setting FD_CLOEXEC. On the first call, a probe is done + * and the result recorded for use by subsequent calls. + * In theory these variables aren't thread-safe, but the worst that can + * happen is that two treads will both do an initial probe + */ +PERLVARI(G, strategy_dup, int, 0) /* doio.c */ +PERLVARI(G, strategy_dup2, int, 0) /* doio.c */ +PERLVARI(G, strategy_open, int, 0) /* doio.c */ +PERLVARI(G, strategy_open3, int, 0) /* doio.c */ +PERLVARI(G, strategy_mkstemp, int, 0) /* doio.c */ +PERLVARI(G, strategy_socket, int, 0) /* doio.c */ +PERLVARI(G, strategy_accept, int, 0) /* doio.c */ +PERLVARI(G, strategy_pipe, int, 0) /* doio.c */ +PERLVARI(G, strategy_socketpair, int, 0) /* doio.c */ |