Prime the duplicate Pod cache the first time is_duplicate_pod() is called.

Previously it was primed when get_pod_metadata() was called. This removes the
undocumented assumption that is_duplicate_pod() will only be called after
get_pod_metadata(), and avoids reading 14 Pod files to calculate their MD5s
unless actually necessary.

This change means that the array references in @{$state{master}} are being
accessed much later during runtime. This reveals that podset() in buildtoc
had been clobbering its callers $_, which happened to be an alias to the
current element of @{$state{master}}.

1 files changed, 1 insertions, 0 deletions

diff --git a/pod/buildtoc b/pod/buildtoc
index 839fbb16a4..c61a425c85 100644
--- a/pod/buildtoc
+++ b/pod/buildtoc
@@ -223,6 +223,7 @@ sub podset {
     my ($pod, $file) = @_;
 
     local $/ = '';
+    local *_;
 
     open my $fh, '<', $file or my_die "Can't open file '$file' for $pod: $!";