summaryrefslogtreecommitdiff
path: root/pp_sort.c
diff options
context:
space:
mode:
authorDavid Mitchell <davem@iabyn.com>2015-10-15 13:48:25 +0100
committerDavid Mitchell <davem@iabyn.com>2016-02-03 08:59:43 +0000
commit2f450c1bae02c0b0fcd87271d9236f76d9575ed3 (patch)
treef7ea3b1444132be8aac2d74dd6d340e355e4892b /pp_sort.c
parent94a11f7c2b35ca4c446f3aa0ffff73539bfd267f (diff)
downloadperl-2f450c1bae02c0b0fcd87271d9236f76d9575ed3.tar.gz
move CX_LEAVE_SCOPE outside the POPFOO's
Currently every POPFOO macro has CX_LEAVE_SCOPE(cx) as its first action. Since this is common code and not specific to a particular POPFOO type, remove it from each POPFOO macro and make each caller of POPFOO explicitly call CX_LEAVE_SCOPE() instead. This should make no functional difference (but will help if you're single-stepping the code in a debugger :-)
Diffstat (limited to 'pp_sort.c')
-rw-r--r--pp_sort.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/pp_sort.c b/pp_sort.c
index 1d6f7d6a95..63214b9487 100644
--- a/pp_sort.c
+++ b/pp_sort.c
@@ -1703,14 +1703,14 @@ PP(pp_sort)
PL_stack_sp = PL_stack_base + cx->blk_oldsp;
+ CX_LEAVE_SCOPE(cx);
if (!(flags & OPf_SPECIAL)) {
assert(CxTYPE(cx) == CXt_SUB);
POPSUB(cx);
}
- else {
+ else
assert(CxTYPE(cx) == CXt_NULL);
- CX_LEAVE_SCOPE(cx);
- }
+ /* there isn't a POPNULL ! */
POPBLOCK(cx);
cxstack_ix--;