Some low-hanging -Wunreachable-code fruits.

- after croak/die/exit (or return), break (or return!) are pointless
  (break is not a terminator/separator, it's a promise of a jump)
- after goto, another goto (!) is pointless
- in some cases (usually function ends) introduce explicit NOT_REACHED
  to make the noreturn nature clearer (do not do this everywhere, though,
  since that would mean adding NOT_REACHED after every croak)
- for the added NOT_REACHED also add /* NOTREACHED */ since
  NOT_REACHED is for gcc (and VC), while the comment is for linters
- declaring variables in switch blocks is just too fragile:
  it kind of works for narrowing the scope (which is nice),
  but breaks the moment there are initializations for the variables
  (they will be skipped!); in some easy cases simply hoist the declarations
  out of the block and move them earlier

There are still a few places left.

1 files changed, 2 insertions, 2 deletions

diff --git a/regexp.h b/regexp.h
index db7ae8be01..3295c4a293 100644
--- a/regexp.h
+++ b/regexp.h
@@ -381,9 +381,9 @@ get_regex_charset_name(const U32 flags, STRLEN* const lenp)
 	case REGEX_ASCII_MORE_RESTRICTED_CHARSET:
 	    *lenp = 2;
 	    return ASCII_MORE_RESTRICT_PAT_MODS;
-        default:
-	    return "?";	    /* Unknown */
     }
+    NOT_REACHED; /* NOTREACHED */
+    return "?";
 }
 
 /* Do we have some sort of anchor? */