diff options
| author | Jim Cromie <jim.cromie@gmail.com> | 2012-10-07 11:10:16 -0600 |
|---|---|---|
| committer | Jarkko Hietaniemi <jhi@iki.fi> | 2014-11-06 20:51:38 -0500 |
| commit | 861a58daef615e7ade791b887911ef3caba8c539 (patch) | |
| tree | fcdbab644fbe6c971487c2d051fb2c717c00b47d /t/TEST | |
| parent | 448bc2e91e255b2610f23d9fe8092c9143dac28e (diff) | |
| download | perl-861a58daef615e7ade791b887911ef3caba8c539.tar.gz | |
t/TEST: $failure doesnt need to use defined
$failure handling in <$results> processing loop does not need extra
subtlety of defined-ness checks - just give it an initial (false)
value, and check for truth.
Diffstat (limited to 't/TEST')
| -rwxr-xr-x | t/TEST | 14 |
1 files changed, 6 insertions, 8 deletions
@@ -531,7 +531,7 @@ EOT my $grind_ct = 0; # count of non-empty valgrind reports my $total_files = @tests; my $good_files = 0; - my $tested_files = 0; + my $tested_files = 0; my $totmax = 0; my %failed_tests; my $toolnm; # valgrind, cachegrind, perf @@ -567,7 +567,7 @@ EOT my $results = _run_test($test, $type); - my $failure; + my $failure = ""; my $next = 0; my $seen_leader = 0; my $seen_ok = 0; @@ -660,7 +660,7 @@ EOT } close $results; - if (not defined $failure) { + if (not $failure) { $failure = 'FAILED--no leader found' unless $seen_leader; } @@ -669,13 +669,11 @@ EOT if ($type eq 'deparse' && !$ENV{KEEP_DEPARSE_FILES}) { unlink "./$test.dp"; } - if (not defined $failure and $next != $max) { + if (not $failure and $next != $max) { $failure="FAILED--expected $max tests, saw $next"; } - if( !defined $failure # don't mask a test failure - and $? ) - { + if (not $failure and $? ) { # don't mask a test failure $failure = "FAILED--non-zero wait status: $?"; } @@ -692,7 +690,7 @@ EOT } } - if (defined $failure) { + if ($failure) { print "${te}$failure\n"; $::bad_files = $::bad_files + 1; if ($test =~ /^base/ && ! defined &DynaLoader::boot_DynaLoader) { |