[perl #123763] Clear target on my $_; split

If a lexical $_ is in scope, then the first argument to split, which
starts out as a match op, will get the pad offset of $_ as its target,
since that’s how implicit lexical $_=~ usually works.

ck_split changes that first argument to a pushre op.  The target
was not being cleared.  That did not cause any problems, until
v5.21.4-408-gfd017c0, which optimised lexical @array = split to write
to split @array directly, by storing making lexical array’s pad offset
the pushre’s target.

You can see the obvious conflict there.  We end up trying to split to
$_, which is not an array.  On a debugging build, you get an assertion
failure when trying to extend $_.  Make the split list long enough,
and you get a crash on non-debugging builds.

debugging$ ./miniperl -e 'my $_; split'
Use of my $_ is experimental at -e line 1.
Assertion failed: (SvTYPE(av) == SVt_PVAV), function Perl_av_extend, file av.c, line 70.

non-debugging$ ./miniperl -e 'my $_; split //, "a"x100000'
Use of my $_ is experimental at -e line 1.
Segmentation fault: 11

1 files changed, 1 insertions, 0 deletions

diff --git a/t/base/lex.t b/t/base/lex.t
index 9a8cf145a5..fdeafb12fa 100644
--- a/t/base/lex.t
+++ b/t/base/lex.t
@@ -502,4 +502,5 @@ eval q|s##[}#e|;
 {
  local $SIG{__WARN__}=sub{};
  eval q|my($_);0=split|;
+ eval q|my $_; @x = split|;
 }