diff options
| author | Michael Witten <mfwitten@gmail.com> | 2011-03-14 06:57:43 +0000 |
|---|---|---|
| committer | Father Chrysostomos <sprout@cpan.org> | 2011-05-18 16:35:16 -0700 |
| commit | 1b95d04f713d9c56e4957326f9f6b0481216a00c (patch) | |
| tree | 9f57b4048cfba9c60f2f933d4e9305cc149dfa80 /t/benchmark | |
| parent | b9f41ca854adae9c928d96cb3c1612b18866516e (diff) | |
| download | perl-1b95d04f713d9c56e4957326f9f6b0481216a00c.tar.gz | |
Clean: Actually use HvUSEDKEYS() instead of HvKEYS()
This:
commit 8aacddc1ea3837f8f1a911d90c644451fc7cfc86
Author: Nick Ing-Simmons <nik@tiuk.ti.com>
Date: Tue Dec 18 15:55:22 2001 +0000
Tidied version of Jeffrey Friedl's <jfriedl@yahoo.com> restricted hashes
- added delete of READONLY value inhibit & test for same
- re-tabbed
p4raw-id: //depot/perlio@13760
essentially deprecated HvKEYS() in favor of HvUSEDKEYS(); this is
explained in line 144 (now 313) of file `hv.h':
/*
* HvKEYS gets the number of keys that actually exist(), and is provided
* for backwards compatibility with old XS code. The core uses HvUSEDKEYS
* (keys, excluding placeholdes) and HvTOTALKEYS (including placeholders)
*/
This commit simply puts that into practice, and is equivalent to running
the following (at least with a35ef416833511da752c4b5b836b7a8915712aab
checked out):
git grep -l HvKEYS | sed /hv.h/d | xargs sed -i s/HvKEYS/HvUSEDKEYS/
Notice that HvKEYS is currently just an alias for HvUSEDKEYS:
$ git show a35ef416833511da752c4b5b836b7a8915712aab:hv.h | sed -n 318p
#define HvKEYS(hv) HvUSEDKEYS(hv)
According to `make tests':
All tests successful.
Diffstat (limited to 't/benchmark')
| -rw-r--r-- | t/benchmark/rt26188-speed-up-keys-on-empty-hash.t | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/benchmark/rt26188-speed-up-keys-on-empty-hash.t b/t/benchmark/rt26188-speed-up-keys-on-empty-hash.t index 155aa3f887..47703829a0 100644 --- a/t/benchmark/rt26188-speed-up-keys-on-empty-hash.t +++ b/t/benchmark/rt26188-speed-up-keys-on-empty-hash.t @@ -86,5 +86,5 @@ __END__ /* quick bailout if the hash is empty anyway. I don't know if placeholders are included in the KEYS count, so a defensive check */ - if (! HvKEYS(hv) && !(flags & HV_ITERNEXT_WANTPLACEHOLDERS) ) + if (! HvUSEDKEYS(hv) && !(flags & HV_ITERNEXT_WANTPLACEHOLDERS) ) return NULL; |