summaryrefslogtreecommitdiff
path: root/t/win32
diff options
context:
space:
mode:
authorTony Cook <tony@develop-help.com>2015-02-10 15:54:16 +1100
committerTony Cook <tony@develop-help.com>2015-02-10 15:54:16 +1100
commitf5fe1b19fc61e51b533b25b128ec7a6f764372da (patch)
tree3885694ffef2c285a5b55c516c07d42e370190c5 /t/win32
parent7082c44063b6e00b0bad96f3d8adec0946f1938c (diff)
downloadperl-f5fe1b19fc61e51b533b25b128ec7a6f764372da.tar.gz
remove the shell fallback from list pipe open on Win32
This is a potential security issue, and while we'd need a deprecation cycle to remove it from system(), there hasn't been a production release of perl with list pipe open, so we can pretend it never was. Without the shell, CreateProcess() won't pick up .cmd or .bat files, which several perl utilities are packaged as on Win32, so use qualified_path() to produce a full executable name.
Diffstat (limited to 't/win32')
-rw-r--r--t/win32/system_tests4
1 files changed, 2 insertions, 2 deletions
diff --git a/t/win32/system_tests b/t/win32/system_tests
index 8307222ffd..91113dbf0b 100644
--- a/t/win32/system_tests
+++ b/t/win32/system_tests
@@ -121,12 +121,12 @@ for my $cmds (@commands) {
$^D = 0;
note "# pipe [".join(";", @cmds, @args). "]";
- if (open my $io, "|-", @cmds, @args) {
+ if (open my $io, "-|", @cmds, @args) {
print <$io>;
close $io;
}
else {
- print "Failed pipe open: $!\n";
+ print STDERR "Failed pipe open [",join(";", @cmds, @args),"]: $!\n";
}
}
}