diff options
author | James E Keenan <jkeenan@cpan.org> | 2022-09-03 12:06:43 +0000 |
---|---|---|
committer | James E Keenan <jkeenan@cpan.org> | 2022-09-12 08:23:14 -0400 |
commit | dcf2c66b4ba2e50408461d7ac13a4782ba26bf1b (patch) | |
tree | fd5c55dc630fe8684d59c9acea610d0151565675 /thread.h | |
parent | 70910c0d8e79acb9fa80f7497dc95defb3a2aba4 (diff) | |
download | perl-dcf2c66b4ba2e50408461d7ac13a4782ba26bf1b.tar.gz |
perlfilter.pod: Retain entry in customized database
pod/perlfilter.pod is (for historical reasons, apparently) maintained
upstream on CPAN as part of the Filter distribution. As such, (i) it
should, generally speaking, only be edited upstream and synched into
core; (ii) needs to be referenced in several places in the
Filter::Util::Call element in %Maintainers::Modules
(Porting/Maintainers.pl); (iii) needs to have an entry in
t/porting/customized.dat (the "customized database") to protect it from
being "overwritten" or accidentally removed.
For all of the above conditions to work together, the
filter_customized() subroutine in t/porting/customized.t needs to be
able to construct a regex which recognizes pod/perlfilter.pod's
weirdness. Prior to this patch it was failing to do so. Thus when
pod/perlfilter.pod was accidentally edited in commit d84bd0bd47, the
need to regenerate the customized database was not recognized. Later,
review of a different pull request which required regeneration of the
customized database spotted the unintentional deletion of the entry for
pod/perlfilter.pod from t/porting/customized.dat.
Addressing this problem is inevitably going to be kludgy, but it will be
less kludgy if done in t/porting/customized.t than in
Porting/Maintainers.pl. This patch modifies the former file to
guarantee that the string 'pod/perlfilter.pod' is matched. After that
modification, 'cd t; ./perl -I../lib porting/customized.t --regen; cd -'
was run. This accomplished the (previously overlooked) removal of
certain entries for Memoize in the customized database while leaving the
entry for pod/perlfilter.pod in that database intact.
If at some point in the future we decide that pod/perlfilter.pod should
be maintained directly in core, we can remove this kludge and simplify
the Filter::Util::Call element in %Maintainers::Modules in
Porting/Maintainers.pl.
For: https://github.com/Perl/perl5/issues/20228.
Should (partially) unblock https://github.com/Perl/perl5/pull/20216.
Diffstat (limited to 'thread.h')
0 files changed, 0 insertions, 0 deletions