diff options
| author | Chris 'BinGOs' Williams <chris@bingosnet.co.uk> | 2017-12-20 19:21:30 +0000 |
|---|---|---|
| committer | Chris 'BinGOs' Williams <chris@bingosnet.co.uk> | 2017-12-20 19:21:30 +0000 |
| commit | d4a50999a5525c2681d59cae5fcd94f94ff897fd (patch) | |
| tree | 32a40dc75f3adab56d77041647407a9a919faf67 /win32/perllib.c | |
| parent | d4abdeed8255ddfdbdd2813d5f1a0e1c7125cacb (diff) | |
| download | perl-d4a50999a5525c2681d59cae5fcd94f94ff897fd.tar.gz | |
Resolve issue with Win32 caused by 0301e8995
From #p5p
[18:12] < xenu> is it just me or is it impossible to build perl using visual c++?
[18:13] < xenu> it fails with 'NMAKE : fatal error U1077: '..\perl.exe' : return code '0x100'"
[18:14] < pink_mist> I'm pretty sure it ought to be possible
[18:14] < xenu> the funny part is that perl.exe built by msvc *always* exits with 255 exit code
[18:14] < xenu> even if you run it like this ..\perl.exe -e "print 1"
[18:14] < xenu> it will print '1' and terminate with exit code 255
[18:42] < xenu> Zefram: 0301e899536a22752f40481d8a1d141b7a7dda82 broke win32
[18:43] < xenu> basically the problem is than PerlRun in win32/perllib.c uses return value of perl_run() as a exit code
[19:08] < BinGOs> xenu: does 'exitstatus = perl_destruct(my_perl);' fix the issue?
[19:20] < xenu> BinGOs: yep
[19:20] < BinGOs> okay cool thanks for confirming.
[19:20] < BinGOs> I'll commit that now.
Diffstat (limited to 'win32/perllib.c')
| -rw-r--r-- | win32/perllib.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/win32/perllib.c b/win32/perllib.c index cf7bf563d2..8a6626fc5e 100644 --- a/win32/perllib.c +++ b/win32/perllib.c @@ -253,7 +253,7 @@ RunPerl(int argc, char **argv, char **env) #endif } - perl_destruct(my_perl); + exitstatus = perl_destruct(my_perl); perl_free(my_perl); #ifdef USE_ITHREADS if (new_perl) { |