summaryrefslogtreecommitdiff
path: root/dist/threads-shared
Commit message (Collapse)AuthorAgeFilesLines
* threads-shared - use pure pragma version of CLANG_DIAG_IGNOREYves Orton2023-03-292-4/+4
| | | | | | | | | | | Otherwise HPUX complains about unreachable statements. "shared.xs", line 707: warning #2111-D: statement is unreachable CLANG_DIAG_RESTORE_STMT; ^ This version should do the same thing, the only difference being it doesnt allow a semicolon on the macro call.
* threads-shared - fixup typo in commentYves Orton2023-03-182-3/+3
|
* Use ppport.h when building dist/ modules in coreLeon Timmermans2023-02-222-10/+7
| | | | By always including `ppport.h`, this simplifies both XS code and tooling around it.
* Change !! to cBOOL() in dist/ext modulesKarl Williamson2022-06-202-2/+2
|
* Use newRV_inc() in threads::shared instead of direct juggling with SvRV_set()Paul "LeoNerd" Evans2021-08-252-6/+3
|
* Only initialize threads::shared interpreter onceLeon Timmermans2021-08-052-10/+12
| | | | | | | | | | Previously, the shared interpreter would be recreated every time the bootstrap was run, in the assumption that the bootstrap would only be run once. This assumption isn't necessarily true if multiple non-cloned interpreters exist. Theoretically there's still a race condition around initialization, but I'm not particularly worried about that.
* dist/threads-shared: use PERL_VERSION compare macroNicolas R2020-08-172-3/+3
|
* Change bug URL from http://rt.perl.org to https://rt.perl.orgMax Maischein2019-10-111-2/+2
| | | | | | | | | | | | | This updates the bug tracker URL from http://rt.perl.org to https://rt.perl.org. There is a place in the code, in corelist.pl, that is sensitive to the URL of the bug tracker. This now understands both versions of the bug tracker URL. Ideally, this will be consolidated once the dust settles. This patch also updates ExtUtils::CBuilder, Safe, threads and threads::shared to point to the new bug tracker URL.
* threads::shared: fix leakDavid Mitchell2019-07-112-6/+13
| | | | | | | | | | | | When assigning a shared reference value to a variable containing a shared string, the PV buffer in the shared space was leaked. For example: my $s :shared = "foo"; my $t :shared = shared_clone(\"bar"); $s = $t; # "foo" in shared space leaked This was showing up as failed smokes under ASan.
* bump $threads::shared::VERSION to 1.60Tony Cook2019-03-081-2/+2
|
* add extra lock tracing to threads::sharedTony Cook2019-03-081-0/+39
| | | | | | | | | | | | | | | This was useful in tracing the cause for the deadlock in #124203. This can be enabled during a build of perl by adding: -Accflags=-DSHARED_TRACE_LOCKS -DDEBUGGING to the Configure command-line. To see the trace at run-time add -DU or -DUv to the perl command-line. The original DEBUG_LOCKS tracing using warn caused extra calls confusing back traces when trying to debug this problem.
* Upgrade to threads::shared 1.59jdhedden2018-11-281-3/+4
| | | | Committer: perldelta entry
* semicolon-friendly diagnostic controlZefram2017-12-162-11/+13
| | | | | | New macros {GCC,CLANG}_DIAG_{IGNORE,RESTORE}_{DECL,STMT}, which take a following semicolon. It is necessary to use the _DECL or _STMT version as appropriate to the context. Fixes [perl #130726].
* Upgrade to threads::shared 1.57jdhedden2017-06-012-4/+5
|
* threads::shared: alloc arenas with correct contextDavid Mitchell2017-04-143-5/+29
| | | | | | | | | | RT #131124 In a couple of places in shared.xs, it calls sv_newmortal() with a perl context different from that currently set by PERL_SET_CONTEXT(). If sv_newmortal() happens to trigger the malloc of a new SV HEAD arena, then under PERL_TRACK_MEMPOOL, this will cause panics when the arena is freed or realloced.
* Upgrade to threads::shared 1.55jdhedden2017-02-261-8/+10
|
* Upgrade to threads::shared 1.54jdhedden2016-12-312-2/+4
|
* Silence one warnings generated during 'make' by clang.Jerry D. Hedden2016-12-292-2/+10
| | | | | | See: https://rt.cpan.org/Ticket/Display.html?id=119529 Committer: Update version number in module's POD. Add perldelta entry.
* Upgrade to threads::shared 1.52jdhedden2016-05-161-4/+9
|
* Upgrade to threads::shared 1.51jdhedden2016-04-302-16/+13
|
* shared.xs: remove dead codeDavid Mitchell2015-11-242-1/+4
| | | | | | | | | | Since v5.23.4-26-g0b057af made static a bunch a functions not used outside their own src files, gcc has been complaining: shared.xs:1172:1: warning: ‘Perl_sharedsv_unlock’ defined but not used [-Wunused-function] Perl_sharedsv_unlock(pTHX_ SV *ssv) So "delete" this function using '#if 0'
* [perl #126452] partly 0b057af7 revert for C++ buildsTony Cook2015-10-261-3/+3
|
* XS staticing in ext and distDaniel Dragan2015-10-262-34/+34
| | | | | | | None of these symbols are exported on Win32 (listed in Makefile.PL with EUMM's FUNCLIST), so they shouldn't be exported on Linux. Making them static saves space in the SOs by removing symbol name strings, and removing runtime plt/got indirection.
* Corrections to spelling and grammatical errors.Lajos Veres2015-01-291-1/+1
| | | | | | | | | Extracted from patch submitted by Lajos Veres in RT #123693. This commit applies those patches to files under dist/ *other than* those pertaining to Tie-File. Update $VERSION in Dumper.pm and Storable.pm after re-applying patches from RT
* Revert "Corrections to spelling and grammatical errors."James E Keenan2015-01-291-1/+1
| | | | | | | | | | | | | This reverts commit 5bf4b3bf13bc4055684a48448b05920845ef7764. On p5p-list, Steve Hay wrote on 2015-01-29: "... these and other changes to Tie-File could break backwards compatibility. The keys of %opt are passed in from user code, so we can't change the expected key from "autodefer_threshhold" to "autodefer_threshold" without also asking users to change their code, which is probably more hassle than it's worth." Parts of the reverted commit will be re-committed from a new patch.
* Corrections to spelling and grammatical errors.Lajos Veres2015-01-281-1/+1
| | | | Extracted from patch submitted by Lajos Veres in RT #123693.
* attempt again to const vtables in threads-sharedDaniel Dragan2015-01-242-11/+11
| | | | | Followup to commit a8c717cfeb and commit 7105b7e7a5 and perl #123549 . This should be C++ compatible even though it leaves some symbols non-static.
* Revert "const + static vtables in threads::shared"Father Chrysostomos2015-01-062-11/+11
| | | | This reverts commit 7105b7e7a5e49caa06b8d7ef71008838ec902227.
* const + static vtables in threads::sharedDaniel Dragan2015-01-052-11/+11
| | | | | | | | | This makes threads::shared have no non-NULL initialized RW static data. Uninitialized and NULL filled RW data like PL_sharedsv_space and prev_signal_hook remain, but on some OSes/CCs (Win32 with special tweaks), this means that now the RW data section in threads::shared shared library has no disk representation. Static the remaining RW vars to trim the symbol table on non-Win32.
* threads: $#shared = N should destroyDavid Mitchell2014-10-142-3/+64
| | | | | | | | | | | When shrinking a shared array by setting $#shared = N, any freed elements should trigger destructors if they are objects, but they weren't. This commit extends the work done by 7d585d2f3001 (which created tmp proxys when abandoning elements of arrays and hashes) to the STORESIZE method, which is what is triggered by $#a assignment (and indirectly by undef @a).
* threads::shared "$#shared = N" off-by-one errorDavid Mitchell2014-10-143-4/+14
| | | | | | | | | | | | | | | | | RT #122950 my @a : shared; $#a = 3; # actually set it to 4 There was a simple off-by-one error in the XS code that handled the STORESIZE tie method (confusing the array size and fill, which differ by 1). Amazingly, there was no test for it, and no-one had noticed up until now. Note that this commit causes three tests in object2.t to fail: this is because fixing the $#shared bug exposed another bug that was being masked by this one. They will be fixed in the next commit
* thrreads::shared: LEAVE in BOOT had wrong contextDavid Mitchell2014-01-201-1/+3
| | | | | | | | | | In Perl_sharedsv_init() - which is called from the threads::shared BOOT code - it creates a new shared interpreter, then tries to undo the ENTER done as the last step of the perl_construct(PL_sharedsv_space) step, with a LEAVE. But the LEAVE was being done in the context of the caller interpreter rather than the shared one. See the thread beginning <52D528FE.20701@havurah-software.org>
* Increase $threads::shared::VERSION to 1.46Father Chrysostomos2014-01-181-2/+2
|
* threads::shared: Don’t link to moving targetsFather Chrysostomos2014-01-181-4/+4
| | | | | | | The Scalar::Util documentation has changed, so the links are broken. But we cannot just update the link targets, as threads::shared is living a double life and may be installed along with an older Scalar::Util.
* threads::shared: fix compiler warningDavid Mitchell2013-11-081-2/+2
| | | | | | | | | make the file name stored in the lock on debugging builds be const char* rather than char*, so that passing __FILE__ doesn't give lots of shared.xs:1287:323: warning: deprecated conversion from string constant to 'char *' [-Wwrite-strings]
* shared.pm: Consistent spaces after dotsFather Chrysostomos2013-11-011-4/+8
|
* threads::shared: Remove redundant description just addedFather Chrysostomos2013-11-011-21/+1
| | | | | | | | | | | In commit fd013656aac I moved the documentation for the two warnings that threads::shared produces from perldiag.pod to shared.pm, without rewording anything. These two warnings had almost identical descriptions, and--I found later--basically repeat some of the documentation of the cond_signal function, so point to that description in the warnings section and avoid repeating things.
* Increase $threads::shared::VERSION to 1.45Father Chrysostomos2013-11-011-2/+2
|
* Move threads::shared warnings from perldiag to shared.pmFather Chrysostomos2013-11-011-0/+32
| | | | following the precedent set by threads.pm.
* Remove fakethr.h and eliminate all references to it and FAKE_THREADSNicholas Clark2013-05-212-3/+3
| | | | | | | | | | fakethr.h and FAKE_THREADS were for a "green" threads implementation of 5005threads. 5005threads itself is long gone, and it's not clear that -DFAKE_THREADS *ever* built correctly. Certainly it did not work for the 5.005 release, and it did not work at the time of the commits for the initial checkin. The closest that it seems to have been to working is around commit c6ee37c52f2ca9e5 (Dec 1997), where the headers no longer contained errors, but perl.c failed to compile.
* bump threads::shared version 1.43Jerry D. Hedden2013-01-141-2/+2
| | | | To sync with the forthcoming CPAN release.
* Don't use a fixed iteration count in dist/threads-shared/t/stress.tNicholas Clark2013-01-111-1/+42
| | | | | | | | | | | Looping 500,000 times takes between 0.025s and 1s depending on hardware and optimisation levels on machines I have access to. For a fixed iteration count, on a particularly slow machine the timeout can fire before all threads have had a realistic chance to complete, but dropping the iteration count will cause fast machines to finish each thread too quickly. So use an initial busy loop (single-thread) to estimate a suitable iteration count to use for the per-thread test loop.
* Upgrade to threads::shared 1.42Jerry D. Hedden2012-10-022-86/+456
|
* Revert "Upgrade to threads::shared 1.42"Father Chrysostomos2012-10-022-428/+68
| | | | This reverts commit 34bd199a87daedeaeadd8e9ef48032c8307eaa94.
* Upgrade to threads::shared 1.42Jerry D. Hedden2012-10-022-68/+428
|
* Upgrade to threads::shared 1.42Jerry D. Hedden2012-10-013-3/+108
|
* Upgrade to threads::shared 1.41Jerry D. Hedden2012-09-082-7/+52
|
* Collapse some code in shared.xsFather Chrysostomos2011-09-081-25/+9
| | | | | In the previous commit, I added duplicate code to make it obvious what was going on.
* [perl #98204] Shared objects not destoryedFather Chrysostomos2011-09-083-55/+85
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Jerry wrote: > threads::shared objects stored inside other > threads::shared structures are not properly destroyed. > When a threads::shared object is 'removed' from a > threads::shared structure (e.g., a hash), the object's > DESTROY method is not called. Later, he said: > When PL_destroyhook and Perl_shared_object_destroy were > added, the problem they were overcoming was that the > destruction of each threads::shared proxy was causing the > underlying shared object's DESTROY method to be called. The > fix provided a refcount check on the shared object so that > the DESTROY method was only called with the shared object > was no longer in use. > > The above works fine when delete() and pop() are used, > because a proxy is created for the stored shared object that > is being deleted (i.e., the value returned by the delete() > call), and when the proxy is destroyed, the object's DESTROY > method is called. > > However, when the stored shared object is 'removed' in some > other manner (e.g., setting the storage location to > 'undef'), there is no proxy involved, and hence DESTROY does > not get called for the object. This commit fixes that by modifying sharedsv_scalar_store, sharedsv_scalar_mg_free and sharedsv_array_mg_CLEAR. Each of those functions now checks whether the current item being freed has sub-items with reference counts of 1. If so, that means the sub-item will be freed as a result of the outer SV’s being freed. It also means that there are no proxy objects and that destructors will hence not be called. So it pushes a new proxy on to the calling con- text’s mortals stack. If there are multiple levels of nested objects, then, when the proxy on the mortals stack is freed, it triggers sharedsv_scalar_mg_free, which goes through the process again. This does not fix the problem for shared objects that still exist (without proxies) at global destruction time. I cannot make that work, as circularities will cause new proxies to be created continu- ously and pushed on to the mortals stack. Also, the proxies may end up being created too late during global destruction, after the mor- tals stack has been emptied, and when there is not enough of the run- time environment left for destructors to run. That will happen if the shared object is referenced by a shared SV that is not an object. The calling context doesn’t know about the object, so it won’t fire the destructor at the object-destroying stage of global destruction. Detecting circularities is also problematic: We would have to keep a hash of ‘seen’ objects in the shared space, but then how would we know when to free that? Letting it leak would affect embedded environments. So this whole trick of creating mortal proxy objects is skipped during global destruction.
* shared.xs: Refactor to simplify S_get_RV’s callersFather Chrysostomos2011-09-081-17/+16
| | | | | | | | | | | | | | | | | | | | | Every function that calls S_get_RV needs this same incantation: S_get_RV(aTHX_ sv, ssv); /* Look ahead for refs of refs */ if (SvROK(SvRV(ssv))) { SvROK_on(SvRV(sv)); S_get_RV(aTHX_ SvRV(sv), SvRV(ssv)); } Also, S_get_RV keeps repeating SvRV(ssv), even though it assigns it to sobj at the top. Also, an upcoming commit will need the ability to pass the referent to S_get_RV. So this patch changes S_get_RV to accept a referent instead (eliminat- ing its multiple use of SvRV) and adds a get_RV macro to take care of the standard calling rite.
View Lorry Controller Status