| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clean up the report created by `perlbug` so that it looks better
when pasted in a GitHub issue:
- Put the 'perl configuration' in a code-block
- Hide some sentences
- Clean up 'Flags' section (it was shown as a very big header and
taking up quite a lot of space)
- Add `**Description**`, `**Steps to Reproduce**` and `**Expected behaviour**`
in the body of the report (similar to the GitHub issue template)
- If this is a report about a core module then also put the name of the Module
at the top (it's still included in 'Flags' as well)
- ...
(There are two newlines added before 'Flags', this is to deal with someone
using `perlbug -b foo`, without the newlines GitHub would make turn the
'foo' into a title)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using an unset variable hides the true intent and
also requires an extra backslash `\$running_under_some_shell`
when used in heredoc.
Note that this could also lead to mistake when using
`\$` in a regular Perl program, as this would be true
and not false as it should be.
Stop recommending the use of an undefined variable for
the shell fallback. Use '0', with a comment
making clear the goal of 'if 0'.
|
|
|
|
|
|
|
|
|
| |
Output filename now always defaults to "perlbug.rep".
Sends by email only if an address is specified with -a,
invoked as perlthanks or with -T, or the prompt is
chosen to send the report to perl5-porters.
Removed option -A as it no longer does anything.
Clarified output to refer to "report" instead of "message".
|
| |
|
|
|
|
|
|
| |
GitHub issue tracker
The perlbug utility and perlbug@perl.org should no longer be used to submit bug reports or patches.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates the bug tracker URL from http://rt.perl.org
to https://rt.perl.org.
There is a place in the code, in corelist.pl, that is sensitive
to the URL of the bug tracker. This now understands both
versions of the bug tracker URL. Ideally, this will be
consolidated once the dust settles.
This patch also updates ExtUtils::CBuilder, Safe, threads
and threads::shared to point to the new bug tracker URL.
|
|
|
|
|
|
| |
This commit moves more URLs from http to https. This time it
affects some source code, that's why it is not bunched up
with the commits affecting pod/*
|
| |
|
|
|
|
|
|
| |
This adds a prompt asking for confirmation if the perlbug report would
overwrite an existing file. My guess is that the normal answer will be
yes.
|
|
|
|
|
|
|
| |
RT 130032: Thanks to Houston Perl Mongers for contributing to this work at
our monthly meeting!
NPD
|
|
|
|
|
|
|
|
|
|
| |
Switch from two-argument form. Filehandle cloning is still done with the two
argument form for backward compatibility.
Committer: Get all porting tests to pass. Increment some $VERSIONs.
Run: ./perl -Ilib regen/mk_invlists.pl; ./perl -Ilib regen/regcharclass.pl
For: RT #130122
|
|
|
|
|
|
|
| |
While currently Encode and Storable are know to attempt to load modules
not included in the core, updates to other modules may lead to those
also attempting to load new modules, so be safe and remove . for those
as well.
|
|
|
|
| |
This fixes tests on Win32.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mail transport agents limit the length of message lines at SMTP time.
One observed limit is 1000 characters per line. Mail user agents typically
work around these limits by MIME-encoding the message. Since perlbug
doesn't do that, it needs to limit the length of its lines manually to
make sure bug reports get delivered.
The longest lines in perlbug reports normally come from Config::myconfig
output, particularly 'config_args', which has been observed to exceed
1000 characters on some configurations, causing report rejection. While
less likely, the list of local patches is another potential source of
overly long lines.
Use Text::Wrap (if available) to wrap the body of the report at an
arbitrarily chosen and hopefully safe limit of 900 characters. No
indentation or continuation line markers are added, though it would
be easy to add those if desired. Attachments and mail headers are not
wrapped.
Bug-Debian: https://bugs.debian.org/822463
|
|
|
|
|
|
| |
_send_message_mailsend() needs to build the message itself rather than
calling build_complete_message() like the other backends, but they can
still share the file reading code, and so can the 'display report' part.
|
|
|
|
|
| |
Passing whitespace in an option through test.pl runperl() doesn't seem
to work, so relax the check in test mode (-t) for noninteractive testing.
|
|
|
|
|
|
|
|
|
|
| |
This makes it possible to drive perlbug noninteractively
without having it go to an infinite loop on end of file.
The change has no effect in non-test mode, where the default answer is
the empty string.
This is groundworks for perlbug unit tests.
|
|
|
|
|
|
|
|
|
|
|
| |
This is groundworks for perlbug unit tests.
Not all of the interactive questions can be overridden on
the command line, so we will have to pipe in commands.
Adapt the test mode ("-t"), which used to just override the
recipient address, for this rather than inventing one more
new option.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Guessing the encoding of a report file prepared ahead of time is
really, well, too much guesswork, plus there are at least a couple
of mistakes in the implementation. And we weren't even trying to
guess for reports created on-the-fly in an editor, which is a bit
inconsistent.
So handle prepared reports the same way as on-the-fly reports and
attachments, which means all I/O is done using the :raw layer.
This is only "Unicode-aware" in the sense that we're aware there
are a lot of encodings out there and we're trying not to mangle
them in transit by accidental conversion. We're not doing any
explicit character set conversions and we shouldn't assert in the
MIME headers that we know what character set we're sending because
we don't.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Try to do input in whatever the locale wants and output raw in
hopes that will best survive mail transport.
Except when reading in a patch file, we'll also use raw for input
because there may be multiple encodings in the patch, and we'll
also use raw for input when reading in the report file that we've
written out raw.
We attempt to detect the locale encoding using the private and
undocumented _get_locale_encoding() function of the deprecated
encoding pragma module. But it's what the open pragma does and
we protect ourselves by checking that it's available and falling
back to an empty layer specification ("<:") if we can't load that
function. That should also give us something workable when there
is no dynamic loading, such as under miniperl.
|
|
|
|
|
|
|
|
|
|
|
| |
The VMS mail utility can't do attachments because it always adds
a blank line in front of any headers you add. So use the Send
From File utility, which has been documented and supported for
any release in the last decade and was latently present before
that.
It takes the whole message verbatim just like sendmail, but also
needs the envelope prepended.
|
|
|
|
|
|
|
|
|
|
|
| |
Log files and other text attachments should also be fine as long
as they aren't big enough to be rejected by RT.
Only text attachments are supported, as other kinds would involve
wrestling with myriad MIME types and possibly content transfer
encodings. This should be fine for binary patches, though, as
git format-patch encodes those in Base85, so the patch file itself
is still text.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
Re-parsing patchlevel.h in Perl by perlbug.PL is error prone
and apparently unnecessary. The same information is available
to perlbug via Config::local_patches().
This fixes [perl #118433].
|
| |
|
|
|
|
| |
Suggested by Dave Mitchell.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
patch does:
perl -pi -e 's/$::opt_(\w)/$opt{$1}/g' perlbug.PL
adds my %opt decl, and in getopts.
drops no warnings 'once'
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
|
|
|
|
|
|
|
| |
Many systems thesedays don't have a valid internet domain name and
perlbug@perl.org does not accept email with a return-path that does not
resolve. Therefore pass the user's address to sendmail so it's less
likely to get stuck in a mail queue somewhere.
|
| |
|
|
|
|
|
|
|
|
|
| |
# New Ticket Created by (Peter J. Acklam)
# Please include the string: [perl #81914]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=81914 >
Signed-off-by: Abigail <abigail@abigail.be>
|
|
|
|
|
| |
the "right" thing and insert a valid "From:", not all of them do,
potentially resulting in dropped mail.
|
|
|
|
|
|
|
|
|
|
| |
The code that guessed a default sender address would under some
circumstances not display this guess to the user with the option to change
it. Specifically, if $Config{cf_me} eq {login id of the user running
perlbug}.
In my case, cf_email got set at build time (Configure default) of
'davem@pigeon.(none)', which was then silently used. Not good!
|
| |
|
|
|
|
| |
Signed-off-by: H.Merijn Brand <h.m.brand@xs4all.nl>
|
|
|
|
|
| |
This patch also make PERL_GIT_UNCOMMITTED_CHANGES useful and thus avoids
always adding the "*" to the 'perl -v' output.
|
|
|
|
|
| |
perlbug doesn't check the return status of Mail::Send and so reports
"Message sent" even if it hasn't:
|
| |
|
| |
|
| |
|
|
|
|
|
| |
but these days it contains macros that expand to patch lists;
for now, just skip these macros. need a proper fix sometime.
|
|
|
|
|
|
|
| |
Where the user names a module that their bug report is about, and we know the
URL for its upstream bug tracker, provide a message to the user explaining
that the core copies the CPAN version directly, and provide the URL for
reporting the bug directly to upstream.
|
|
|
|
|
|
| |
From: Abigail (via RT) <perlbug-followup@perl.org>
Date: Tue, 16 Dec 2008 13:09:56 -0800
Message-ID: <rt-3.6.HEAD-15883-1229461796-1657.61418-75-0@perl.org>
|
|
|
| |
p4raw-id: //depot/perl@35120
|