summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXinchen Hui <laruence@php.net>2015-01-20 10:11:48 +0800
committerXinchen Hui <laruence@php.net>2015-01-20 10:11:48 +0800
commit020610ee40fcabacf0330243dd4af1a2b599ce6b (patch)
tree62e403ae66d449091dd864329068a770a686b14b
parent1ee7845f5712a2d8fb7419bd1e93e49c95be5d8d (diff)
downloadphp-git-020610ee40fcabacf0330243dd4af1a2b599ce6b.tar.gz
Remove addslashes_str
-rw-r--r--ext/mysqli/mysqli.c11
-rw-r--r--ext/pcre/php_pcre.c2
-rw-r--r--ext/standard/php_string.h1
-rw-r--r--ext/standard/string.c14
4 files changed, 7 insertions, 21 deletions
diff --git a/ext/mysqli/mysqli.c b/ext/mysqli/mysqli.c
index 4fa6783b3c..2debf256e2 100644
--- a/ext/mysqli/mysqli.c
+++ b/ext/mysqli/mysqli.c
@@ -1200,16 +1200,7 @@ void php_mysqli_fetch_into_hash_aux(zval *return_value, MYSQL_RES * result, zend
#endif
{
-#if PHP_API_VERSION < 20100412
- /* check if we need magic quotes */
- if (PG(magic_quotes_runtime)) {
- ZVAL_STR(&res, php_addslashes(row[i], field_len[i], 0));
- } else {
-#endif
- ZVAL_STRINGL(&res, row[i], field_len[i]);
-#if PHP_API_VERSION < 20100412
- }
-#endif
+ ZVAL_STRINGL(&res, row[i], field_len[i]);
}
if (fetchtype & MYSQLI_NUM) {
diff --git a/ext/pcre/php_pcre.c b/ext/pcre/php_pcre.c
index 1b3bd8f1de..3e5d96eb90 100644
--- a/ext/pcre/php_pcre.c
+++ b/ext/pcre/php_pcre.c
@@ -1026,7 +1026,7 @@ static zend_string *preg_do_eval(char *eval_str, int eval_str_len, char *subject
match = subject + offsets[backref<<1];
match_len = offsets[(backref<<1)+1] - offsets[backref<<1];
if (match_len) {
- esc_match = php_addslashes_str(match, match_len, 0);
+ esc_match = php_addslashes(zend_string_init(match, match_len, 0), 1);
} else {
esc_match = zend_string_init(match, match_len, 0);
}
diff --git a/ext/standard/php_string.h b/ext/standard/php_string.h
index 0e0120e9f1..1cca1438cb 100644
--- a/ext/standard/php_string.h
+++ b/ext/standard/php_string.h
@@ -124,7 +124,6 @@ PHPAPI zend_string *php_string_toupper(zend_string *s);
PHPAPI zend_string *php_string_tolower(zend_string *s);
PHPAPI char *php_strtr(char *str, size_t len, char *str_from, char *str_to, size_t trlen);
PHPAPI zend_string *php_addslashes(zend_string *str, int should_free);
-PHPAPI zend_string *php_addslashes_str(const char *str, size_t length, int should_free);
PHPAPI zend_string *php_addcslashes(const char *str, size_t length, int freeit, char *what, size_t wlength);
PHPAPI void php_stripslashes(char *str, size_t *len);
PHPAPI void php_stripcslashes(char *str, size_t *len);
diff --git a/ext/standard/string.c b/ext/standard/string.c
index 6848081e15..78c7a25ddc 100644
--- a/ext/standard/string.c
+++ b/ext/standard/string.c
@@ -3910,7 +3910,11 @@ PHPAPI zend_string *php_addslashes(zend_string *str, int should_free)
}
}
- return zend_string_copy(str);
+ if (!should_free) {
+ return zend_string_copy(str);
+ }
+
+ return str;
do_escape:
offset = source - (char *)str->val;
@@ -3952,14 +3956,6 @@ do_escape:
}
/* }}} */
-/* {{{ php_addslashes_str
- */
-PHPAPI zend_string *php_addslashes_str(const char *str, size_t length, int should_free)
-{
- return php_addslashes(zend_string_init(str, length, 0), 1);
-}
-/* }}} */
-
#define _HEB_BLOCK_TYPE_ENG 1
#define _HEB_BLOCK_TYPE_HEB 2
#define isheb(c) (((((unsigned char) c) >= 224) && (((unsigned char) c) <= 250)) ? 1 : 0)