summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristoph M. Becker <cmbecker69@gmx.de>2021-02-08 18:44:20 +0100
committerChristoph M. Becker <cmbecker69@gmx.de>2021-02-08 18:44:20 +0100
commit050214b1f1497bfebe031e32a40c197080511844 (patch)
tree0e1d887e51e10dd5f78839a2f48c757e2ab3dd86
parent19680f886f02fd8fe4557e6146f927aaa6782d05 (diff)
parentf731477cd798615f9f8412bd2d95a40b911b64fa (diff)
downloadphp-git-050214b1f1497bfebe031e32a40c197080511844.tar.gz
Merge branch 'PHP-8.0'
* PHP-8.0: Fix #80706: mail(): Headers after Bcc headers may be ignored
-rw-r--r--ext/standard/tests/mail/bug80706.phpt76
-rw-r--r--win32/sendmail.c2
2 files changed, 77 insertions, 1 deletions
diff --git a/ext/standard/tests/mail/bug80706.phpt b/ext/standard/tests/mail/bug80706.phpt
new file mode 100644
index 0000000000..b478c49c4b
--- /dev/null
+++ b/ext/standard/tests/mail/bug80706.phpt
@@ -0,0 +1,76 @@
+--TEST--
+Bug #72964 (White space not unfolded for CC/Bcc headers)
+--SKIPIF--
+<?php
+if (PHP_OS_FAMILY !== 'Windows') die('skip Windows only test');
+if (getenv("SKIP_SLOW_TESTS")) die('skip slow test');
+require_once __DIR__ . '/mail_skipif.inc';
+?>
+--INI--
+SMTP=localhost
+smtp_port=25
+--FILE--
+<?php
+require_once __DIR__ . '/mail_include.inc';
+
+function find_and_delete_message($username, $subject) {
+ global $default_mailbox, $password;
+
+ $imap_stream = imap_open($default_mailbox, $username, $password);
+ if ($imap_stream === false) {
+ die("Cannot connect to IMAP server $server: " . imap_last_error() . "\n");
+ }
+
+ $found = false;
+ $repeat_count = 20; // we will repeat a max of 20 times
+ while (!$found && $repeat_count > 0) {
+ // sleep for a while to allow msg to be delivered
+ sleep(1);
+
+ $num_messages = imap_check($imap_stream)->Nmsgs;
+ for ($i = $num_messages; $i > 0; $i--) {
+ $info = imap_headerinfo($imap_stream, $i);
+ if ($info->subject === $subject) {
+ $header = imap_fetchheader($imap_stream, $i);
+ echo "X-Mailer header found: ";
+ var_dump(strpos($header, 'X-Mailer: bug80706') !== false);
+ imap_delete($imap_stream, $i);
+ $found = true;
+ break;
+ }
+ }
+ $repeat_count--;
+ }
+
+ imap_close($imap_stream, CL_EXPUNGE);
+ return $found;
+}
+
+$to = "{$users[1]}@$domain";
+$subject = bin2hex(random_bytes(16));
+$message = 'hello';
+$headers = "From: webmaster@example.com\r\n"
+ . "Bcc: {$users[2]}@$domain\r\n"
+ . "X-Mailer: bug80706";
+
+$res = mail($to, $subject, $message, $headers);
+if ($res !== true) {
+ die("TEST FAILED : Unable to send test email\n");
+} else {
+ echo "Message sent OK\n";
+}
+
+foreach ([$users[1], $users[2]] as $user) {
+ if (!find_and_delete_message("$user@$domain", $subject)) {
+ echo "TEST FAILED: email not delivered\n";
+ } else {
+ echo "TEST PASSED: Message sent and deleted OK\n";
+ }
+}
+?>
+--EXPECT--
+Message sent OK
+X-Mailer header found: bool(true)
+TEST PASSED: Message sent and deleted OK
+X-Mailer header found: bool(true)
+TEST PASSED: Message sent and deleted OK
diff --git a/win32/sendmail.c b/win32/sendmail.c
index 059bc946ee..da5bddde37 100644
--- a/win32/sendmail.c
+++ b/win32/sendmail.c
@@ -527,7 +527,7 @@ static int SendText(char *RPath, const char *Subject, const char *mailTo, char *
header we know it was the last thing. */
pos2 = pos1;
} else {
- char *pos3 = NULL;
+ char *pos3 = pos2;
while (pos2[2] == ' ' || pos2[2] == '\t') {
pos3 = strstr(pos2 + 2, "\r\n");
if (pos3 != NULL) {