diff options
author | Xinchen Hui <laruence@gmail.com> | 2016-03-29 17:14:48 +0800 |
---|---|---|
committer | Xinchen Hui <laruence@gmail.com> | 2016-03-29 17:14:48 +0800 |
commit | 0a2746fb4be96fd3eff6f1989f3a07ca878b4bcf (patch) | |
tree | fa3a8e934855d1cd27d207ed28ea81ce16c6cd05 | |
parent | 45035b1b8d76a3eb9cc9aac0bf78ec879e7f7322 (diff) | |
parent | 2e6d70787c93413daecbea529bf0f74fa901d1db (diff) | |
download | php-git-0a2746fb4be96fd3eff6f1989f3a07ca878b4bcf.tar.gz |
Merge branch 'PHP-7.0'
* PHP-7.0:
Fixed bug #71914 (Reference is lost in "switch")
-rw-r--r-- | Zend/tests/bug71914.phpt | 25 | ||||
-rw-r--r-- | Zend/zend_vm_def.h | 2 | ||||
-rw-r--r-- | Zend/zend_vm_execute.h | 18 |
3 files changed, 35 insertions, 10 deletions
diff --git a/Zend/tests/bug71914.phpt b/Zend/tests/bug71914.phpt new file mode 100644 index 0000000000..8f825f89ec --- /dev/null +++ b/Zend/tests/bug71914.phpt @@ -0,0 +1,25 @@ +--TEST-- +Bug #71914 (Reference is lost in "switch") +--FILE-- +<?php + +function bug(&$value) { + switch ($value) { + case "xxxx": + $value = true; + break; + } +} + + +function test($arr, &$dummy) { + bug($arr["str"]); + var_dump($arr["str"]); +} + + +$array = array("str" => "xxxx"); +test($array, $array["str"]); +?> +--EXPECT-- +bool(true) diff --git a/Zend/zend_vm_def.h b/Zend/zend_vm_def.h index 9539b6e2ed..2557509381 100644 --- a/Zend/zend_vm_def.h +++ b/Zend/zend_vm_def.h @@ -5054,7 +5054,7 @@ ZEND_VM_HANDLER(48, ZEND_CASE, CONST|TMPVAR|CV, CONST|TMPVAR|CV) SAVE_OPLINE(); if (OP1_TYPE == IS_CV && UNEXPECTED(Z_TYPE_P(op1) == IS_UNDEF)) { op1 = GET_OP1_UNDEF_CV(op1, BP_VAR_R); - } else if ((OP1_TYPE & (IS_VAR|IS_CV)) && UNEXPECTED(Z_ISREF_P(op1))) { + } else if ((OP1_TYPE & IS_VAR) && UNEXPECTED(Z_ISREF_P(op1))) { /* Don't keep lock on reference, lock the value instead */ if (UNEXPECTED(Z_REFCOUNT_P(op1) == 1)) { ZVAL_UNREF(op1); diff --git a/Zend/zend_vm_execute.h b/Zend/zend_vm_execute.h index 4eee6dd3ea..ac7ac1580e 100644 --- a/Zend/zend_vm_execute.h +++ b/Zend/zend_vm_execute.h @@ -6294,7 +6294,7 @@ static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CASE_SPEC_CONST_CONST_HANDLER( SAVE_OPLINE(); if (IS_CONST == IS_CV && UNEXPECTED(Z_TYPE_P(op1) == IS_UNDEF)) { op1 = GET_OP1_UNDEF_CV(op1, BP_VAR_R); - } else if ((IS_CONST & (IS_VAR|IS_CV)) && UNEXPECTED(Z_ISREF_P(op1))) { + } else if ((IS_CONST & IS_VAR) && UNEXPECTED(Z_ISREF_P(op1))) { /* Don't keep lock on reference, lock the value instead */ if (UNEXPECTED(Z_REFCOUNT_P(op1) == 1)) { ZVAL_UNREF(op1); @@ -10152,7 +10152,7 @@ static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CASE_SPEC_CONST_CV_HANDLER(ZEN SAVE_OPLINE(); if (IS_CONST == IS_CV && UNEXPECTED(Z_TYPE_P(op1) == IS_UNDEF)) { op1 = GET_OP1_UNDEF_CV(op1, BP_VAR_R); - } else if ((IS_CONST & (IS_VAR|IS_CV)) && UNEXPECTED(Z_ISREF_P(op1))) { + } else if ((IS_CONST & IS_VAR) && UNEXPECTED(Z_ISREF_P(op1))) { /* Don't keep lock on reference, lock the value instead */ if (UNEXPECTED(Z_REFCOUNT_P(op1) == 1)) { ZVAL_UNREF(op1); @@ -12010,7 +12010,7 @@ static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CASE_SPEC_CONST_TMPVAR_HANDLER SAVE_OPLINE(); if (IS_CONST == IS_CV && UNEXPECTED(Z_TYPE_P(op1) == IS_UNDEF)) { op1 = GET_OP1_UNDEF_CV(op1, BP_VAR_R); - } else if ((IS_CONST & (IS_VAR|IS_CV)) && UNEXPECTED(Z_ISREF_P(op1))) { + } else if ((IS_CONST & IS_VAR) && UNEXPECTED(Z_ISREF_P(op1))) { /* Don't keep lock on reference, lock the value instead */ if (UNEXPECTED(Z_REFCOUNT_P(op1) == 1)) { ZVAL_UNREF(op1); @@ -39602,7 +39602,7 @@ static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CASE_SPEC_CV_CONST_HANDLER(ZEN SAVE_OPLINE(); if (IS_CV == IS_CV && UNEXPECTED(Z_TYPE_P(op1) == IS_UNDEF)) { op1 = GET_OP1_UNDEF_CV(op1, BP_VAR_R); - } else if ((IS_CV & (IS_VAR|IS_CV)) && UNEXPECTED(Z_ISREF_P(op1))) { + } else if ((IS_CV & IS_VAR) && UNEXPECTED(Z_ISREF_P(op1))) { /* Don't keep lock on reference, lock the value instead */ if (UNEXPECTED(Z_REFCOUNT_P(op1) == 1)) { ZVAL_UNREF(op1); @@ -46090,7 +46090,7 @@ static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CASE_SPEC_CV_CV_HANDLER(ZEND_O SAVE_OPLINE(); if (IS_CV == IS_CV && UNEXPECTED(Z_TYPE_P(op1) == IS_UNDEF)) { op1 = GET_OP1_UNDEF_CV(op1, BP_VAR_R); - } else if ((IS_CV & (IS_VAR|IS_CV)) && UNEXPECTED(Z_ISREF_P(op1))) { + } else if ((IS_CV & IS_VAR) && UNEXPECTED(Z_ISREF_P(op1))) { /* Don't keep lock on reference, lock the value instead */ if (UNEXPECTED(Z_REFCOUNT_P(op1) == 1)) { ZVAL_UNREF(op1); @@ -49631,7 +49631,7 @@ static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CASE_SPEC_CV_TMPVAR_HANDLER(ZE SAVE_OPLINE(); if (IS_CV == IS_CV && UNEXPECTED(Z_TYPE_P(op1) == IS_UNDEF)) { op1 = GET_OP1_UNDEF_CV(op1, BP_VAR_R); - } else if ((IS_CV & (IS_VAR|IS_CV)) && UNEXPECTED(Z_ISREF_P(op1))) { + } else if ((IS_CV & IS_VAR) && UNEXPECTED(Z_ISREF_P(op1))) { /* Don't keep lock on reference, lock the value instead */ if (UNEXPECTED(Z_REFCOUNT_P(op1) == 1)) { ZVAL_UNREF(op1); @@ -51855,7 +51855,7 @@ static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CASE_SPEC_TMPVAR_CONST_HANDLER SAVE_OPLINE(); if ((IS_TMP_VAR|IS_VAR) == IS_CV && UNEXPECTED(Z_TYPE_P(op1) == IS_UNDEF)) { op1 = GET_OP1_UNDEF_CV(op1, BP_VAR_R); - } else if (((IS_TMP_VAR|IS_VAR) & (IS_VAR|IS_CV)) && UNEXPECTED(Z_ISREF_P(op1))) { + } else if (((IS_TMP_VAR|IS_VAR) & IS_VAR) && UNEXPECTED(Z_ISREF_P(op1))) { /* Don't keep lock on reference, lock the value instead */ if (UNEXPECTED(Z_REFCOUNT_P(op1) == 1)) { ZVAL_UNREF(op1); @@ -54195,7 +54195,7 @@ static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CASE_SPEC_TMPVAR_CV_HANDLER(ZE SAVE_OPLINE(); if ((IS_TMP_VAR|IS_VAR) == IS_CV && UNEXPECTED(Z_TYPE_P(op1) == IS_UNDEF)) { op1 = GET_OP1_UNDEF_CV(op1, BP_VAR_R); - } else if (((IS_TMP_VAR|IS_VAR) & (IS_VAR|IS_CV)) && UNEXPECTED(Z_ISREF_P(op1))) { + } else if (((IS_TMP_VAR|IS_VAR) & IS_VAR) && UNEXPECTED(Z_ISREF_P(op1))) { /* Don't keep lock on reference, lock the value instead */ if (UNEXPECTED(Z_REFCOUNT_P(op1) == 1)) { ZVAL_UNREF(op1); @@ -55440,7 +55440,7 @@ static ZEND_OPCODE_HANDLER_RET ZEND_FASTCALL ZEND_CASE_SPEC_TMPVAR_TMPVAR_HANDLE SAVE_OPLINE(); if ((IS_TMP_VAR|IS_VAR) == IS_CV && UNEXPECTED(Z_TYPE_P(op1) == IS_UNDEF)) { op1 = GET_OP1_UNDEF_CV(op1, BP_VAR_R); - } else if (((IS_TMP_VAR|IS_VAR) & (IS_VAR|IS_CV)) && UNEXPECTED(Z_ISREF_P(op1))) { + } else if (((IS_TMP_VAR|IS_VAR) & IS_VAR) && UNEXPECTED(Z_ISREF_P(op1))) { /* Don't keep lock on reference, lock the value instead */ if (UNEXPECTED(Z_REFCOUNT_P(op1) == 1)) { ZVAL_UNREF(op1); |