summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGeorge Peter Banyard <girgias@php.net>2020-01-20 23:17:24 +0100
committerGeorge Peter Banyard <girgias@php.net>2020-01-21 13:18:13 +0100
commit13178087c7eaa092667ec3b713e26cba1b919969 (patch)
treef4595f814d30658244c41607d83186091e79590e
parent5a6f3de8ac419ffee41a3ea19176100b31b3adfb (diff)
downloadphp-git-13178087c7eaa092667ec3b713e26cba1b919969.tar.gz
Drop the custom 'v' format from snprintf custom implementation.
Extensions should instead use the standard 's' format. Closes GH-5100
-rw-r--r--UPGRADING.INTERNALS3
-rw-r--r--main/snprintf.c1
2 files changed, 3 insertions, 1 deletions
diff --git a/UPGRADING.INTERNALS b/UPGRADING.INTERNALS
index 62492bab39..1714e26eb0 100644
--- a/UPGRADING.INTERNALS
+++ b/UPGRADING.INTERNALS
@@ -86,6 +86,9 @@ PHP 8.0 INTERNALS UPGRADE NOTES
Use the ZEND_LONG_FMT, ZEND_ULONG_FMT and ZEND_XLONG_FMT macros defined in
php-src/Zend/zend_long.h
+ The 'v' format from the custom snprintf implementation has been removed.
+ Use the standard 's' format instead.
+
========================
2. Build system changes
========================
diff --git a/main/snprintf.c b/main/snprintf.c
index 2dd2aa276f..4c20367ea3 100644
--- a/main/snprintf.c
+++ b/main/snprintf.c
@@ -961,7 +961,6 @@ static int format_converter(register buffy * odp, const char *fmt, va_list ap) /
case 's':
- case 'v':
s = va_arg(ap, char *);
if (s != NULL) {
s_len = strlen(s);