summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAntony Dovgal <tony2001@php.net>2007-04-04 19:52:19 +0000
committerAntony Dovgal <tony2001@php.net>2007-04-04 19:52:19 +0000
commit39f9184fa6e8ffa949bb1e1d85310dcc0096be0f (patch)
tree46ff293b3771dedd87e7fa87c268fa2776626cd9
parentfebad95f3f585784c6564169f5e94c1ca3d9dee8 (diff)
downloadphp-git-39f9184fa6e8ffa949bb1e1d85310dcc0096be0f.tar.gz
MFH: fix #40998 (long session array keys are truncated)
-rw-r--r--NEWS1
-rw-r--r--ext/session/session.c2
2 files changed, 2 insertions, 1 deletions
diff --git a/NEWS b/NEWS
index efc0362429..58d1c9d733 100644
--- a/NEWS
+++ b/NEWS
@@ -37,6 +37,7 @@ PHP NEWS
- Fixed zend_llist_remove_tail (Michael Wallner, Dmitry)
- Fixed a thread safety issue in gd gif read code (Nuno, Roman Nemecek)
- Fixed CVE-2007-1001, GD wbmp used with invalid image size (Pierre)
+- Fixed bug #40998 (long session array keys are truncated). (Tony)
- Fixed bug #40921 (php_default_post_reader crashes when post_max_size is
exceeded). (trickie at gmail dot com, Ilia)
- Fixed bug #40915 (addcslashes unexpected behavior with binary input). (Tony)
diff --git a/ext/session/session.c b/ext/session/session.c
index 72606a22d9..cdb23ff2ef 100644
--- a/ext/session/session.c
+++ b/ext/session/session.c
@@ -523,7 +523,7 @@ PS_SERIALIZER_ENCODE_FUNC(php)
PHP_VAR_SERIALIZE_INIT(var_hash);
PS_ENCODE_LOOP(
- smart_str_appendl(&buf, key, (unsigned char) key_length);
+ smart_str_appendl(&buf, key, key_length);
if (memchr(key, PS_DELIMITER, key_length)) {
PHP_VAR_SERIALIZE_DESTROY(var_hash);
smart_str_free(&buf);