summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristoph M. Becker <cmbecker69@gmx.de>2020-02-08 17:07:49 +0100
committerChristoph M. Becker <cmbecker69@gmx.de>2020-02-08 17:07:49 +0100
commit42e7de1518eb511cea1bc0a6ecd4254ecc44b38a (patch)
tree47386d57df76484eea840db0b310fd3cd3a85109
parent377ac2a9034291a8d4c8c0962488cabccec676e0 (diff)
parent01eab11cee751bf64364a0b778e05c9018abb75a (diff)
downloadphp-git-42e7de1518eb511cea1bc0a6ecd4254ecc44b38a.tar.gz
Merge branch 'PHP-7.4'
* PHP-7.4: Fix #79248: Traversing empty VT_ARRAY throws com_exception
-rw-r--r--ext/com_dotnet/com_iterator.c2
-rw-r--r--ext/com_dotnet/tests/bug79248.phpt16
2 files changed, 17 insertions, 1 deletions
diff --git a/ext/com_dotnet/com_iterator.c b/ext/com_dotnet/com_iterator.c
index 7b031f4192..0272d48cd3 100644
--- a/ext/com_dotnet/com_iterator.c
+++ b/ext/com_dotnet/com_iterator.c
@@ -185,7 +185,7 @@ zend_object_iterator *php_com_iter_get(zend_class_entry *ce, zval *object, int b
SafeArrayGetUBound(V_ARRAY(&I->safe_array), 1, &I->sa_max);
/* pre-fetch the element */
- if (php_com_safearray_get_elem(&I->safe_array, &I->v, bound)) {
+ if (I->sa_max >= bound && php_com_safearray_get_elem(&I->safe_array, &I->v, bound)) {
I->key = bound;
ZVAL_NULL(&ptr);
php_com_zval_from_variant(&ptr, &I->v, I->code_page);
diff --git a/ext/com_dotnet/tests/bug79248.phpt b/ext/com_dotnet/tests/bug79248.phpt
new file mode 100644
index 0000000000..fda67551a7
--- /dev/null
+++ b/ext/com_dotnet/tests/bug79248.phpt
@@ -0,0 +1,16 @@
+--TEST--
+Bug #79248 (Traversing empty VT_ARRAY throws com_exception)
+--SKIPIF--
+<?php
+if (!extension_loaded('com_dotnet')) die('skip com_dotnet extension not available');
+?>
+--FILE--
+<?php
+$v = new variant([], VT_ARRAY);
+foreach ($v as $el) {
+ var_dump($el);
+}
+echo "done\n";
+?>
+--EXPECT--
+done