summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMáté Kocsis <kocsismate@woohoolabs.com>2021-03-15 13:11:57 +0100
committerMáté Kocsis <kocsismate@woohoolabs.com>2021-03-15 13:11:57 +0100
commit4833309bd29d14f2e7b3694e13a361d0fd44c343 (patch)
tree95bef738e8fa48d50f4b2935fae7c7e6df9b81ce
parentf7751f2d8b67dcba22bd9e6c3384a85d6aed0a21 (diff)
downloadphp-git-4833309bd29d14f2e7b3694e13a361d0fd44c343.tar.gz
Use typed properties in ext/mysqli
Closes GH-6739
-rw-r--r--ext/mysqli/mysqli.stub.php125
-rw-r--r--ext/mysqli/mysqli_arginfo.h162
-rw-r--r--ext/mysqli/mysqli_prop.c142
-rw-r--r--ext/mysqli/tests/mysqli_class_mysqli_driver_interface.phpt3
-rw-r--r--ext/mysqli/tests/mysqli_class_mysqli_interface.phpt8
-rw-r--r--ext/mysqli/tests/mysqli_class_mysqli_properties_no_conn.phpt36
-rw-r--r--ext/mysqli/tests/mysqli_class_mysqli_result_interface.phpt5
-rw-r--r--ext/mysqli/tests/mysqli_class_mysqli_stmt_interface.phpt10
8 files changed, 201 insertions, 290 deletions
diff --git a/ext/mysqli/mysqli.stub.php b/ext/mysqli/mysqli.stub.php
index 7bb10b3aa3..9956778c6e 100644
--- a/ext/mysqli/mysqli.stub.php
+++ b/ext/mysqli/mysqli.stub.php
@@ -4,77 +4,56 @@
final class mysqli_driver
{
- /** @var string|null */
- public $client_info;
+ public string $client_info;
- /** @var int|null */
- public $client_version;
+ public int $client_version;
- /** @var int|null */
- public $driver_version;
+ public int $driver_version;
- /** @var bool|null */
- public $reconnect;
+ /** @var bool */
+ public $reconnect = false;
- /** @var int|null */
- public $report_mode;
+ /** @var int */
+ public $report_mode = 0;
}
class mysqli
{
- /** @var int|string|null */
- public $affected_rows;
+ public int|string $affected_rows;
- /** @var string|null */
- public $client_info;
+ public string $client_info;
- /** @var string|null */
- public $client_version;
+ public int $client_version;
- /** @var int|null */
- public $connect_errno;
+ public int $connect_errno;
- /** @var string|null */
- public $connect_error;
+ public ?string $connect_error;
- /** @var int|string|null */
- public $errno;
+ public int $errno;
- /** @var string|null */
- public $error;
+ public string $error;
- /** @var array|null */
- public $error_list;
+ public array $error_list;
- /** @var int|null */
- public $field_count;
+ public int $field_count;
- /** @var string|null */
- public $host_info;
+ public string $host_info;
- /** @var string|null */
- public $info;
+ public ?string $info;
- /** @var int|string|null */
- public $insert_id;
+ public int|string $insert_id;
- /** @var string|null */
- public $server_info;
+ public string $server_info;
- /** @var int|string|null */
- public $server_version;
+ public int $server_version;
- /** @var string|null */
- public $sqlstate;
+ public string $sqlstate;
- /** @var int|string|null */
- public $protocol_version;
+ public int $protocol_version;
- /** @var int|string|null */
- public $thread_id;
+ public int $thread_id;
- /** @var int|string|null */
- public $warning_count;
+ public int $warning_count;
public function __construct(
?string $hostname = null,
@@ -370,20 +349,15 @@ class mysqli
class mysqli_result implements IteratorAggregate
{
- /** @var int|string|null */
- public $current_field;
+ public int $current_field;
- /** @var int|string|null */
- public $field_count;
+ public int $field_count;
- /** @var array|null */
- public $lengths;
+ public ?array $lengths;
- /** @var int|string|null */
- public $num_rows;
+ public int|string $num_rows;
- /** @var int|null */
- public $type;
+ public int $type;
public function __construct(mysqli $mysql, int $result_mode = MYSQLI_STORE_RESULT) {}
@@ -470,35 +444,25 @@ class mysqli_result implements IteratorAggregate
class mysqli_stmt
{
- /** @var int|string|null */
- public $affected_rows;
+ public int|string $affected_rows;
- /** @var int|string|null */
- public $insert_id;
+ public int|string $insert_id;
- /** @var int|string|null */
- public $num_rows;
+ public int|string $num_rows;
- /** @var int|string|null */
- public $param_count;
+ public int $param_count;
- /** @var int|string|null */
- public $field_count;
+ public int $field_count;
- /** @var int|string|null */
- public $errno;
+ public int $errno;
- /** @var string|null */
- public $error;
+ public string $error;
- /** @var array|null */
- public $error_list;
+ public array $error_list;
- /** @var string|null */
- public $sqlstate;
+ public string $sqlstate;
- /** @var int|null */
- public $id;
+ public int $id;
public function __construct(mysqli $mysql, ?string $query = null) {}
@@ -623,14 +587,11 @@ class mysqli_stmt
final class mysqli_warning
{
- /** @var string|null */
- public $message;
+ public string $message;
- /** @var string|null */
- public $sqlstate;
+ public string $sqlstate;
- /** @var int|null */
- public $errno;
+ public int $errno;
private function __construct() {}
diff --git a/ext/mysqli/mysqli_arginfo.h b/ext/mysqli/mysqli_arginfo.h
index 5fe2cd74d9..9c55a6bfc8 100644
--- a/ext/mysqli/mysqli_arginfo.h
+++ b/ext/mysqli/mysqli_arginfo.h
@@ -1,5 +1,5 @@
/* This is a generated file, edit the .stub.php file instead.
- * Stub hash: efd018f81d09a704e3a9cea00dd562feb48ca0bb */
+ * Stub hash: 56499df713b79c1e9efc19cf8be45aa98028172c */
ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_mysqli_affected_rows, 0, 1, MAY_BE_LONG|MAY_BE_STRING)
ZEND_ARG_OBJ_INFO(0, mysql, mysqli, 0)
@@ -1049,31 +1049,31 @@ static zend_class_entry *register_class_mysqli_driver(void)
class_entry->ce_flags |= ZEND_ACC_FINAL;
zval property_client_info_default_value;
- ZVAL_NULL(&property_client_info_default_value);
+ ZVAL_UNDEF(&property_client_info_default_value);
zend_string *property_client_info_name = zend_string_init("client_info", sizeof("client_info") - 1, 1);
- zend_declare_property_ex(class_entry, property_client_info_name, &property_client_info_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_client_info_name, &property_client_info_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_STRING));
zend_string_release(property_client_info_name);
zval property_client_version_default_value;
- ZVAL_NULL(&property_client_version_default_value);
+ ZVAL_UNDEF(&property_client_version_default_value);
zend_string *property_client_version_name = zend_string_init("client_version", sizeof("client_version") - 1, 1);
- zend_declare_property_ex(class_entry, property_client_version_name, &property_client_version_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_client_version_name, &property_client_version_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_client_version_name);
zval property_driver_version_default_value;
- ZVAL_NULL(&property_driver_version_default_value);
+ ZVAL_UNDEF(&property_driver_version_default_value);
zend_string *property_driver_version_name = zend_string_init("driver_version", sizeof("driver_version") - 1, 1);
- zend_declare_property_ex(class_entry, property_driver_version_name, &property_driver_version_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_driver_version_name, &property_driver_version_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_driver_version_name);
zval property_reconnect_default_value;
- ZVAL_NULL(&property_reconnect_default_value);
+ ZVAL_BOOL(&property_reconnect_default_value, 0);
zend_string *property_reconnect_name = zend_string_init("reconnect", sizeof("reconnect") - 1, 1);
zend_declare_property_ex(class_entry, property_reconnect_name, &property_reconnect_default_value, ZEND_ACC_PUBLIC, NULL);
zend_string_release(property_reconnect_name);
zval property_report_mode_default_value;
- ZVAL_NULL(&property_report_mode_default_value);
+ ZVAL_LONG(&property_report_mode_default_value, 0);
zend_string *property_report_mode_name = zend_string_init("report_mode", sizeof("report_mode") - 1, 1);
zend_declare_property_ex(class_entry, property_report_mode_name, &property_report_mode_default_value, ZEND_ACC_PUBLIC, NULL);
zend_string_release(property_report_mode_name);
@@ -1089,111 +1089,111 @@ static zend_class_entry *register_class_mysqli(void)
class_entry = zend_register_internal_class_ex(&ce, NULL);
zval property_affected_rows_default_value;
- ZVAL_NULL(&property_affected_rows_default_value);
+ ZVAL_UNDEF(&property_affected_rows_default_value);
zend_string *property_affected_rows_name = zend_string_init("affected_rows", sizeof("affected_rows") - 1, 1);
- zend_declare_property_ex(class_entry, property_affected_rows_name, &property_affected_rows_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_affected_rows_name, &property_affected_rows_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG|MAY_BE_STRING));
zend_string_release(property_affected_rows_name);
zval property_client_info_default_value;
- ZVAL_NULL(&property_client_info_default_value);
+ ZVAL_UNDEF(&property_client_info_default_value);
zend_string *property_client_info_name = zend_string_init("client_info", sizeof("client_info") - 1, 1);
- zend_declare_property_ex(class_entry, property_client_info_name, &property_client_info_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_client_info_name, &property_client_info_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_STRING));
zend_string_release(property_client_info_name);
zval property_client_version_default_value;
- ZVAL_NULL(&property_client_version_default_value);
+ ZVAL_UNDEF(&property_client_version_default_value);
zend_string *property_client_version_name = zend_string_init("client_version", sizeof("client_version") - 1, 1);
- zend_declare_property_ex(class_entry, property_client_version_name, &property_client_version_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_client_version_name, &property_client_version_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_client_version_name);
zval property_connect_errno_default_value;
- ZVAL_NULL(&property_connect_errno_default_value);
+ ZVAL_UNDEF(&property_connect_errno_default_value);
zend_string *property_connect_errno_name = zend_string_init("connect_errno", sizeof("connect_errno") - 1, 1);
- zend_declare_property_ex(class_entry, property_connect_errno_name, &property_connect_errno_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_connect_errno_name, &property_connect_errno_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_connect_errno_name);
zval property_connect_error_default_value;
- ZVAL_NULL(&property_connect_error_default_value);
+ ZVAL_UNDEF(&property_connect_error_default_value);
zend_string *property_connect_error_name = zend_string_init("connect_error", sizeof("connect_error") - 1, 1);
- zend_declare_property_ex(class_entry, property_connect_error_name, &property_connect_error_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_connect_error_name, &property_connect_error_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_STRING|MAY_BE_NULL));
zend_string_release(property_connect_error_name);
zval property_errno_default_value;
- ZVAL_NULL(&property_errno_default_value);
+ ZVAL_UNDEF(&property_errno_default_value);
zend_string *property_errno_name = zend_string_init("errno", sizeof("errno") - 1, 1);
- zend_declare_property_ex(class_entry, property_errno_name, &property_errno_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_errno_name, &property_errno_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_errno_name);
zval property_error_default_value;
- ZVAL_NULL(&property_error_default_value);
+ ZVAL_UNDEF(&property_error_default_value);
zend_string *property_error_name = zend_string_init("error", sizeof("error") - 1, 1);
- zend_declare_property_ex(class_entry, property_error_name, &property_error_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_error_name, &property_error_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_STRING));
zend_string_release(property_error_name);
zval property_error_list_default_value;
- ZVAL_NULL(&property_error_list_default_value);
+ ZVAL_UNDEF(&property_error_list_default_value);
zend_string *property_error_list_name = zend_string_init("error_list", sizeof("error_list") - 1, 1);
- zend_declare_property_ex(class_entry, property_error_list_name, &property_error_list_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_error_list_name, &property_error_list_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_ARRAY));
zend_string_release(property_error_list_name);
zval property_field_count_default_value;
- ZVAL_NULL(&property_field_count_default_value);
+ ZVAL_UNDEF(&property_field_count_default_value);
zend_string *property_field_count_name = zend_string_init("field_count", sizeof("field_count") - 1, 1);
- zend_declare_property_ex(class_entry, property_field_count_name, &property_field_count_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_field_count_name, &property_field_count_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_field_count_name);
zval property_host_info_default_value;
- ZVAL_NULL(&property_host_info_default_value);
+ ZVAL_UNDEF(&property_host_info_default_value);
zend_string *property_host_info_name = zend_string_init("host_info", sizeof("host_info") - 1, 1);
- zend_declare_property_ex(class_entry, property_host_info_name, &property_host_info_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_host_info_name, &property_host_info_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_STRING));
zend_string_release(property_host_info_name);
zval property_info_default_value;
- ZVAL_NULL(&property_info_default_value);
+ ZVAL_UNDEF(&property_info_default_value);
zend_string *property_info_name = zend_string_init("info", sizeof("info") - 1, 1);
- zend_declare_property_ex(class_entry, property_info_name, &property_info_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_info_name, &property_info_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_STRING|MAY_BE_NULL));
zend_string_release(property_info_name);
zval property_insert_id_default_value;
- ZVAL_NULL(&property_insert_id_default_value);
+ ZVAL_UNDEF(&property_insert_id_default_value);
zend_string *property_insert_id_name = zend_string_init("insert_id", sizeof("insert_id") - 1, 1);
- zend_declare_property_ex(class_entry, property_insert_id_name, &property_insert_id_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_insert_id_name, &property_insert_id_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG|MAY_BE_STRING));
zend_string_release(property_insert_id_name);
zval property_server_info_default_value;
- ZVAL_NULL(&property_server_info_default_value);
+ ZVAL_UNDEF(&property_server_info_default_value);
zend_string *property_server_info_name = zend_string_init("server_info", sizeof("server_info") - 1, 1);
- zend_declare_property_ex(class_entry, property_server_info_name, &property_server_info_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_server_info_name, &property_server_info_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_STRING));
zend_string_release(property_server_info_name);
zval property_server_version_default_value;
- ZVAL_NULL(&property_server_version_default_value);
+ ZVAL_UNDEF(&property_server_version_default_value);
zend_string *property_server_version_name = zend_string_init("server_version", sizeof("server_version") - 1, 1);
- zend_declare_property_ex(class_entry, property_server_version_name, &property_server_version_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_server_version_name, &property_server_version_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_server_version_name);
zval property_sqlstate_default_value;
- ZVAL_NULL(&property_sqlstate_default_value);
+ ZVAL_UNDEF(&property_sqlstate_default_value);
zend_string *property_sqlstate_name = zend_string_init("sqlstate", sizeof("sqlstate") - 1, 1);
- zend_declare_property_ex(class_entry, property_sqlstate_name, &property_sqlstate_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_sqlstate_name, &property_sqlstate_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_STRING));
zend_string_release(property_sqlstate_name);
zval property_protocol_version_default_value;
- ZVAL_NULL(&property_protocol_version_default_value);
+ ZVAL_UNDEF(&property_protocol_version_default_value);
zend_string *property_protocol_version_name = zend_string_init("protocol_version", sizeof("protocol_version") - 1, 1);
- zend_declare_property_ex(class_entry, property_protocol_version_name, &property_protocol_version_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_protocol_version_name, &property_protocol_version_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_protocol_version_name);
zval property_thread_id_default_value;
- ZVAL_NULL(&property_thread_id_default_value);
+ ZVAL_UNDEF(&property_thread_id_default_value);
zend_string *property_thread_id_name = zend_string_init("thread_id", sizeof("thread_id") - 1, 1);
- zend_declare_property_ex(class_entry, property_thread_id_name, &property_thread_id_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_thread_id_name, &property_thread_id_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_thread_id_name);
zval property_warning_count_default_value;
- ZVAL_NULL(&property_warning_count_default_value);
+ ZVAL_UNDEF(&property_warning_count_default_value);
zend_string *property_warning_count_name = zend_string_init("warning_count", sizeof("warning_count") - 1, 1);
- zend_declare_property_ex(class_entry, property_warning_count_name, &property_warning_count_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_warning_count_name, &property_warning_count_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_warning_count_name);
return class_entry;
@@ -1208,33 +1208,33 @@ static zend_class_entry *register_class_mysqli_result(zend_class_entry *class_en
zend_class_implements(class_entry, 1, class_entry_IteratorAggregate);
zval property_current_field_default_value;
- ZVAL_NULL(&property_current_field_default_value);
+ ZVAL_UNDEF(&property_current_field_default_value);
zend_string *property_current_field_name = zend_string_init("current_field", sizeof("current_field") - 1, 1);
- zend_declare_property_ex(class_entry, property_current_field_name, &property_current_field_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_current_field_name, &property_current_field_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_current_field_name);
zval property_field_count_default_value;
- ZVAL_NULL(&property_field_count_default_value);
+ ZVAL_UNDEF(&property_field_count_default_value);
zend_string *property_field_count_name = zend_string_init("field_count", sizeof("field_count") - 1, 1);
- zend_declare_property_ex(class_entry, property_field_count_name, &property_field_count_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_field_count_name, &property_field_count_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_field_count_name);
zval property_lengths_default_value;
- ZVAL_NULL(&property_lengths_default_value);
+ ZVAL_UNDEF(&property_lengths_default_value);
zend_string *property_lengths_name = zend_string_init("lengths", sizeof("lengths") - 1, 1);
- zend_declare_property_ex(class_entry, property_lengths_name, &property_lengths_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_lengths_name, &property_lengths_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_ARRAY|MAY_BE_NULL));
zend_string_release(property_lengths_name);
zval property_num_rows_default_value;
- ZVAL_NULL(&property_num_rows_default_value);
+ ZVAL_UNDEF(&property_num_rows_default_value);
zend_string *property_num_rows_name = zend_string_init("num_rows", sizeof("num_rows") - 1, 1);
- zend_declare_property_ex(class_entry, property_num_rows_name, &property_num_rows_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_num_rows_name, &property_num_rows_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG|MAY_BE_STRING));
zend_string_release(property_num_rows_name);
zval property_type_default_value;
- ZVAL_NULL(&property_type_default_value);
+ ZVAL_UNDEF(&property_type_default_value);
zend_string *property_type_name = zend_string_init("type", sizeof("type") - 1, 1);
- zend_declare_property_ex(class_entry, property_type_name, &property_type_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_type_name, &property_type_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_type_name);
return class_entry;
@@ -1248,63 +1248,63 @@ static zend_class_entry *register_class_mysqli_stmt(void)
class_entry = zend_register_internal_class_ex(&ce, NULL);
zval property_affected_rows_default_value;
- ZVAL_NULL(&property_affected_rows_default_value);
+ ZVAL_UNDEF(&property_affected_rows_default_value);
zend_string *property_affected_rows_name = zend_string_init("affected_rows", sizeof("affected_rows") - 1, 1);
- zend_declare_property_ex(class_entry, property_affected_rows_name, &property_affected_rows_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_affected_rows_name, &property_affected_rows_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG|MAY_BE_STRING));
zend_string_release(property_affected_rows_name);
zval property_insert_id_default_value;
- ZVAL_NULL(&property_insert_id_default_value);
+ ZVAL_UNDEF(&property_insert_id_default_value);
zend_string *property_insert_id_name = zend_string_init("insert_id", sizeof("insert_id") - 1, 1);
- zend_declare_property_ex(class_entry, property_insert_id_name, &property_insert_id_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_insert_id_name, &property_insert_id_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG|MAY_BE_STRING));
zend_string_release(property_insert_id_name);
zval property_num_rows_default_value;
- ZVAL_NULL(&property_num_rows_default_value);
+ ZVAL_UNDEF(&property_num_rows_default_value);
zend_string *property_num_rows_name = zend_string_init("num_rows", sizeof("num_rows") - 1, 1);
- zend_declare_property_ex(class_entry, property_num_rows_name, &property_num_rows_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_num_rows_name, &property_num_rows_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG|MAY_BE_STRING));
zend_string_release(property_num_rows_name);
zval property_param_count_default_value;
- ZVAL_NULL(&property_param_count_default_value);
+ ZVAL_UNDEF(&property_param_count_default_value);
zend_string *property_param_count_name = zend_string_init("param_count", sizeof("param_count") - 1, 1);
- zend_declare_property_ex(class_entry, property_param_count_name, &property_param_count_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_param_count_name, &property_param_count_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_param_count_name);
zval property_field_count_default_value;
- ZVAL_NULL(&property_field_count_default_value);
+ ZVAL_UNDEF(&property_field_count_default_value);
zend_string *property_field_count_name = zend_string_init("field_count", sizeof("field_count") - 1, 1);
- zend_declare_property_ex(class_entry, property_field_count_name, &property_field_count_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_field_count_name, &property_field_count_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_field_count_name);
zval property_errno_default_value;
- ZVAL_NULL(&property_errno_default_value);
+ ZVAL_UNDEF(&property_errno_default_value);
zend_string *property_errno_name = zend_string_init("errno", sizeof("errno") - 1, 1);
- zend_declare_property_ex(class_entry, property_errno_name, &property_errno_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_errno_name, &property_errno_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_errno_name);
zval property_error_default_value;
- ZVAL_NULL(&property_error_default_value);
+ ZVAL_UNDEF(&property_error_default_value);
zend_string *property_error_name = zend_string_init("error", sizeof("error") - 1, 1);
- zend_declare_property_ex(class_entry, property_error_name, &property_error_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_error_name, &property_error_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_STRING));
zend_string_release(property_error_name);
zval property_error_list_default_value;
- ZVAL_NULL(&property_error_list_default_value);
+ ZVAL_UNDEF(&property_error_list_default_value);
zend_string *property_error_list_name = zend_string_init("error_list", sizeof("error_list") - 1, 1);
- zend_declare_property_ex(class_entry, property_error_list_name, &property_error_list_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_error_list_name, &property_error_list_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_ARRAY));
zend_string_release(property_error_list_name);
zval property_sqlstate_default_value;
- ZVAL_NULL(&property_sqlstate_default_value);
+ ZVAL_UNDEF(&property_sqlstate_default_value);
zend_string *property_sqlstate_name = zend_string_init("sqlstate", sizeof("sqlstate") - 1, 1);
- zend_declare_property_ex(class_entry, property_sqlstate_name, &property_sqlstate_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_sqlstate_name, &property_sqlstate_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_STRING));
zend_string_release(property_sqlstate_name);
zval property_id_default_value;
- ZVAL_NULL(&property_id_default_value);
+ ZVAL_UNDEF(&property_id_default_value);
zend_string *property_id_name = zend_string_init("id", sizeof("id") - 1, 1);
- zend_declare_property_ex(class_entry, property_id_name, &property_id_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_id_name, &property_id_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_id_name);
return class_entry;
@@ -1319,21 +1319,21 @@ static zend_class_entry *register_class_mysqli_warning(void)
class_entry->ce_flags |= ZEND_ACC_FINAL;
zval property_message_default_value;
- ZVAL_NULL(&property_message_default_value);
+ ZVAL_UNDEF(&property_message_default_value);
zend_string *property_message_name = zend_string_init("message", sizeof("message") - 1, 1);
- zend_declare_property_ex(class_entry, property_message_name, &property_message_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_message_name, &property_message_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_STRING));
zend_string_release(property_message_name);
zval property_sqlstate_default_value;
- ZVAL_NULL(&property_sqlstate_default_value);
+ ZVAL_UNDEF(&property_sqlstate_default_value);
zend_string *property_sqlstate_name = zend_string_init("sqlstate", sizeof("sqlstate") - 1, 1);
- zend_declare_property_ex(class_entry, property_sqlstate_name, &property_sqlstate_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_sqlstate_name, &property_sqlstate_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_STRING));
zend_string_release(property_sqlstate_name);
zval property_errno_default_value;
- ZVAL_NULL(&property_errno_default_value);
+ ZVAL_UNDEF(&property_errno_default_value);
zend_string *property_errno_name = zend_string_init("errno", sizeof("errno") - 1, 1);
- zend_declare_property_ex(class_entry, property_errno_name, &property_errno_default_value, ZEND_ACC_PUBLIC, NULL);
+ zend_declare_typed_property(class_entry, property_errno_name, &property_errno_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release(property_errno_name);
return class_entry;
diff --git a/ext/mysqli/mysqli_prop.c b/ext/mysqli/mysqli_prop.c
index a00346ffcd..a44af2a5ed 100644
--- a/ext/mysqli/mysqli_prop.c
+++ b/ext/mysqli/mysqli_prop.c
@@ -71,42 +71,60 @@ if (!obj->ptr) { \
p = (MYSQL_STMT *)((MY_STMT *)((MYSQLI_RESOURCE *)(obj->ptr))->ptr)->stmt; \
}
-#define MYSQLI_MAP_PROPERTY_FUNC_LONG( __func, __int_func, __get_type, __ret_type, __ret_type_sprint_mod)\
+#define MYSQLI_MAP_PROPERTY_FUNC_LONG_OR_STR( __func, __int_func, __get_type, __ret_type, __ret_type_sprint_mod)\
static int __func(mysqli_object *obj, zval *retval, bool quiet) \
{\
__ret_type l;\
__get_type;\
- if (!p) {\
- ZVAL_NULL(retval);\
- } else {\
- l = (__ret_type)__int_func(p);\
- if (l < ZEND_LONG_MAX) {\
- ZVAL_LONG(retval, (zend_long) l);\
- } else { \
- ZVAL_NEW_STR(retval, strpprintf(0, __ret_type_sprint_mod, l)); \
- } \
+ ZEND_ASSERT(p);\
+ l = (__ret_type)__int_func(p);\
+ if (l < ZEND_LONG_MAX) {\
+ ZVAL_LONG(retval, (zend_long) l);\
+ } else { \
+ ZVAL_NEW_STR(retval, strpprintf(0, __ret_type_sprint_mod, l)); \
} \
return SUCCESS; \
}
-#define MYSQLI_MAP_PROPERTY_FUNC_STRING(__func, __int_func, __get_type)\
+#define MYSQLI_MAP_PROPERTY_FUNC_LONG( __func, __int_func, __get_type, __ret_type, __ret_type_sprint_mod)\
+static int __func(mysqli_object *obj, zval *retval, bool quiet) \
+{\
+ __ret_type l;\
+ __get_type;\
+ ZEND_ASSERT(p);\
+ l = (__ret_type)__int_func(p);\
+ ZEND_ASSERT(l < ZEND_LONG_MAX);\
+ ZVAL_LONG(retval, (zend_long) l);\
+ return SUCCESS; \
+}
+
+#define MYSQLI_MAP_PROPERTY_FUNC_STR_OR_NULL(__func, __int_func, __get_type)\
static int __func(mysqli_object *obj, zval *retval, bool quiet)\
{\
char *c;\
__get_type;\
- if (!p) {\
- ZVAL_NULL(retval);\
+ ZEND_ASSERT(p);\
+ c = (char *)__int_func(p);\
+ if (c) {\
+ ZVAL_STRING(retval, c);\
} else {\
- c = (char *)__int_func(p);\
- if (!c) {\
- ZVAL_NULL(retval);\
- } else {\
- ZVAL_STRING(retval, c);\
- }\
+ ZVAL_NULL(retval);\
}\
return SUCCESS; \
}
+#define MYSQLI_MAP_PROPERTY_FUNC_STR(__func, __int_func, __get_type)\
+static int __func(mysqli_object *obj, zval *retval, bool quiet)\
+{\
+ char *c;\
+ __get_type;\
+ ZEND_ASSERT(p);\
+ c = (char *)__int_func(p);\
+ ZEND_ASSERT(c);\
+ ZVAL_STRING(retval, c);\
+ return SUCCESS; \
+}
+
/* {{{ property link_client_version_read */
static int link_client_version_read(mysqli_object *obj, zval *retval, bool quiet)
{
@@ -153,27 +171,22 @@ static int link_affected_rows_read(mysqli_object *obj, zval *retval, bool quiet)
MY_MYSQL *mysql;
my_ulonglong rc;
- CHECK_STATUS(MYSQLI_STATUS_INITIALIZED, quiet);
+ CHECK_STATUS(MYSQLI_STATUS_VALID, quiet);
mysql = (MY_MYSQL *)((MYSQLI_RESOURCE *)(obj->ptr))->ptr;
+ ZEND_ASSERT(mysql);
- if (!mysql) {
- ZVAL_NULL(retval);
- } else {
- CHECK_STATUS(MYSQLI_STATUS_VALID, quiet);
-
- rc = mysql_affected_rows(mysql->mysql);
+ rc = mysql_affected_rows(mysql->mysql);
- if (rc == (my_ulonglong) -1) {
- ZVAL_LONG(retval, -1);
- return SUCCESS;
- }
+ if (rc == (my_ulonglong) -1) {
+ ZVAL_LONG(retval, -1);
+ return SUCCESS;
+ }
- if (rc < ZEND_LONG_MAX) {
- ZVAL_LONG(retval, (zend_long) rc);
- } else {
- ZVAL_NEW_STR(retval, strpprintf(0, MYSQLI_LLU_SPEC, rc));
- }
+ if (rc < ZEND_LONG_MAX) {
+ ZVAL_LONG(retval, (zend_long) rc);
+ } else {
+ ZVAL_NEW_STR(retval, strpprintf(0, MYSQLI_LLU_SPEC, rc));
}
return SUCCESS;
@@ -227,15 +240,15 @@ static int link_error_list_read(mysqli_object *obj, zval *retval, bool quiet)
/* link properties */
MYSQLI_MAP_PROPERTY_FUNC_LONG(link_errno_read, mysql_errno, MYSQLI_GET_MYSQL(MYSQLI_STATUS_INITIALIZED), zend_ulong, ZEND_ULONG_FMT)
-MYSQLI_MAP_PROPERTY_FUNC_STRING(link_error_read, mysql_error, MYSQLI_GET_MYSQL(MYSQLI_STATUS_INITIALIZED))
+MYSQLI_MAP_PROPERTY_FUNC_STR(link_error_read, mysql_error, MYSQLI_GET_MYSQL(MYSQLI_STATUS_INITIALIZED))
MYSQLI_MAP_PROPERTY_FUNC_LONG(link_field_count_read, mysql_field_count, MYSQLI_GET_MYSQL(MYSQLI_STATUS_VALID), zend_ulong, ZEND_ULONG_FMT)
-MYSQLI_MAP_PROPERTY_FUNC_STRING(link_host_info_read, mysql_get_host_info, MYSQLI_GET_MYSQL(MYSQLI_STATUS_VALID))
-MYSQLI_MAP_PROPERTY_FUNC_STRING(link_info_read, mysql_info, MYSQLI_GET_MYSQL(MYSQLI_STATUS_VALID))
-MYSQLI_MAP_PROPERTY_FUNC_LONG(link_insert_id_read, mysql_insert_id, MYSQLI_GET_MYSQL(MYSQLI_STATUS_VALID), my_ulonglong, MYSQLI_LLU_SPEC)
+MYSQLI_MAP_PROPERTY_FUNC_STR(link_host_info_read, mysql_get_host_info, MYSQLI_GET_MYSQL(MYSQLI_STATUS_VALID))
+MYSQLI_MAP_PROPERTY_FUNC_STR_OR_NULL(link_info_read, mysql_info, MYSQLI_GET_MYSQL(MYSQLI_STATUS_VALID))
+MYSQLI_MAP_PROPERTY_FUNC_LONG_OR_STR(link_insert_id_read, mysql_insert_id, MYSQLI_GET_MYSQL(MYSQLI_STATUS_VALID), my_ulonglong, MYSQLI_LLU_SPEC)
MYSQLI_MAP_PROPERTY_FUNC_LONG(link_protocol_version_read, mysql_get_proto_info, MYSQLI_GET_MYSQL(MYSQLI_STATUS_VALID), zend_ulong, ZEND_ULONG_FMT)
-MYSQLI_MAP_PROPERTY_FUNC_STRING(link_server_info_read, mysql_get_server_info, MYSQLI_GET_MYSQL(MYSQLI_STATUS_VALID))
+MYSQLI_MAP_PROPERTY_FUNC_STR(link_server_info_read, mysql_get_server_info, MYSQLI_GET_MYSQL(MYSQLI_STATUS_VALID))
MYSQLI_MAP_PROPERTY_FUNC_LONG(link_server_version_read, mysql_get_server_version, MYSQLI_GET_MYSQL(MYSQLI_STATUS_VALID), zend_ulong, ZEND_ULONG_FMT)
-MYSQLI_MAP_PROPERTY_FUNC_STRING(link_sqlstate_read, mysql_sqlstate, MYSQLI_GET_MYSQL(MYSQLI_STATUS_VALID))
+MYSQLI_MAP_PROPERTY_FUNC_STR(link_sqlstate_read, mysql_sqlstate, MYSQLI_GET_MYSQL(MYSQLI_STATUS_VALID))
MYSQLI_MAP_PROPERTY_FUNC_LONG(link_thread_id_read, mysql_thread_id, MYSQLI_GET_MYSQL(MYSQLI_STATUS_VALID), zend_ulong, ZEND_ULONG_FMT)
MYSQLI_MAP_PROPERTY_FUNC_LONG(link_warning_count_read, mysql_warning_count, MYSQLI_GET_MYSQL(MYSQLI_STATUS_VALID), zend_ulong, ZEND_ULONG_FMT)
@@ -249,11 +262,8 @@ static int result_type_read(mysqli_object *obj, zval *retval, bool quiet)
CHECK_STATUS(MYSQLI_STATUS_VALID, quiet);
p = (MYSQL_RES *)((MYSQLI_RESOURCE *)(obj->ptr))->ptr;
- if (!p) {
- ZVAL_NULL(retval);
- } else {
- ZVAL_LONG(retval, mysqli_result_is_unbuffered(p) ? MYSQLI_USE_RESULT:MYSQLI_STORE_RESULT);
- }
+ ZEND_ASSERT(p);
+ ZVAL_LONG(retval, mysqli_result_is_unbuffered(p) ? MYSQLI_USE_RESULT:MYSQLI_STORE_RESULT);
return SUCCESS;
}
@@ -291,7 +301,7 @@ static int result_lengths_read(mysqli_object *obj, zval *retval, bool quiet)
MYSQLI_MAP_PROPERTY_FUNC_LONG(result_current_field_read, mysql_field_tell, MYSQLI_GET_RESULT(MYSQLI_STATUS_VALID), zend_ulong, ZEND_ULONG_FMT)
MYSQLI_MAP_PROPERTY_FUNC_LONG(result_field_count_read, mysql_num_fields, MYSQLI_GET_RESULT(MYSQLI_STATUS_VALID), zend_ulong, ZEND_ULONG_FMT)
-MYSQLI_MAP_PROPERTY_FUNC_LONG(result_num_rows_read, mysql_num_rows, MYSQLI_GET_RESULT(MYSQLI_STATUS_VALID), my_ulonglong, MYSQLI_LLU_SPEC)
+MYSQLI_MAP_PROPERTY_FUNC_LONG_OR_STR(result_num_rows_read, mysql_num_rows, MYSQLI_GET_RESULT(MYSQLI_STATUS_VALID), my_ulonglong, MYSQLI_LLU_SPEC)
/* statement properties */
@@ -304,11 +314,8 @@ static int stmt_id_read(mysqli_object *obj, zval *retval, bool quiet)
p = (MY_STMT*)((MYSQLI_RESOURCE *)(obj->ptr))->ptr;
- if (!p) {
- ZVAL_NULL(retval);
- } else {
- ZVAL_LONG(retval, mysqli_stmt_get_id(p->stmt));
- }
+ ZEND_ASSERT(p);
+ ZVAL_LONG(retval, mysqli_stmt_get_id(p->stmt));
return SUCCESS;
}
@@ -324,21 +331,18 @@ static int stmt_affected_rows_read(mysqli_object *obj, zval *retval, bool quiet)
p = (MY_STMT *)((MYSQLI_RESOURCE *)(obj->ptr))->ptr;
- if (!p) {
- ZVAL_NULL(retval);
- } else {
- rc = mysql_stmt_affected_rows(p->stmt);
+ ZEND_ASSERT(p);
+ rc = mysql_stmt_affected_rows(p->stmt);
- if (rc == (my_ulonglong) -1) {
- ZVAL_LONG(retval, -1);
- return SUCCESS;
- }
+ if (rc == (my_ulonglong) -1) {
+ ZVAL_LONG(retval, -1);
+ return SUCCESS;
+ }
- if (rc < ZEND_LONG_MAX) {
- ZVAL_LONG(retval, (zend_long) rc);
- } else {
- ZVAL_NEW_STR(retval, strpprintf(0, MYSQLI_LLU_SPEC, rc));
- }
+ if (rc < ZEND_LONG_MAX) {
+ ZVAL_LONG(retval, (zend_long) rc);
+ } else {
+ ZVAL_NEW_STR(retval, strpprintf(0, MYSQLI_LLU_SPEC, rc));
}
return SUCCESS;
@@ -389,13 +393,13 @@ static int stmt_error_list_read(mysqli_object *obj, zval *retval, bool quiet)
}
/* }}} */
-MYSQLI_MAP_PROPERTY_FUNC_LONG(stmt_insert_id_read, mysql_stmt_insert_id, MYSQLI_GET_STMT(MYSQLI_STATUS_VALID), my_ulonglong, MYSQLI_LLU_SPEC)
-MYSQLI_MAP_PROPERTY_FUNC_LONG(stmt_num_rows_read, mysql_stmt_num_rows, MYSQLI_GET_STMT(MYSQLI_STATUS_VALID), my_ulonglong, MYSQLI_LLU_SPEC)
+MYSQLI_MAP_PROPERTY_FUNC_LONG_OR_STR(stmt_insert_id_read, mysql_stmt_insert_id, MYSQLI_GET_STMT(MYSQLI_STATUS_VALID), my_ulonglong, MYSQLI_LLU_SPEC)
+MYSQLI_MAP_PROPERTY_FUNC_LONG_OR_STR(stmt_num_rows_read, mysql_stmt_num_rows, MYSQLI_GET_STMT(MYSQLI_STATUS_VALID), my_ulonglong, MYSQLI_LLU_SPEC)
MYSQLI_MAP_PROPERTY_FUNC_LONG(stmt_param_count_read, mysql_stmt_param_count, MYSQLI_GET_STMT(MYSQLI_STATUS_VALID), zend_ulong, ZEND_ULONG_FMT)
MYSQLI_MAP_PROPERTY_FUNC_LONG(stmt_field_count_read, mysql_stmt_field_count, MYSQLI_GET_STMT(MYSQLI_STATUS_VALID), zend_ulong, ZEND_ULONG_FMT)
MYSQLI_MAP_PROPERTY_FUNC_LONG(stmt_errno_read, mysql_stmt_errno, MYSQLI_GET_STMT(MYSQLI_STATUS_INITIALIZED), zend_ulong, ZEND_ULONG_FMT)
-MYSQLI_MAP_PROPERTY_FUNC_STRING(stmt_error_read, mysql_stmt_error, MYSQLI_GET_STMT(MYSQLI_STATUS_INITIALIZED))
-MYSQLI_MAP_PROPERTY_FUNC_STRING(stmt_sqlstate_read, mysql_stmt_sqlstate, MYSQLI_GET_STMT(MYSQLI_STATUS_INITIALIZED))
+MYSQLI_MAP_PROPERTY_FUNC_STR(stmt_error_read, mysql_stmt_error, MYSQLI_GET_STMT(MYSQLI_STATUS_INITIALIZED))
+MYSQLI_MAP_PROPERTY_FUNC_STR(stmt_sqlstate_read, mysql_stmt_sqlstate, MYSQLI_GET_STMT(MYSQLI_STATUS_INITIALIZED))
/* }}} */
const mysqli_property_entry mysqli_link_property_entries[] = {
diff --git a/ext/mysqli/tests/mysqli_class_mysqli_driver_interface.phpt b/ext/mysqli/tests/mysqli_class_mysqli_driver_interface.phpt
index e5ffc262ab..ebf9c7f2b7 100644
--- a/ext/mysqli/tests/mysqli_class_mysqli_driver_interface.phpt
+++ b/ext/mysqli/tests/mysqli_class_mysqli_driver_interface.phpt
@@ -93,9 +93,6 @@ reconnect
report_mode
Object variables:
-client_info
-client_version
-driver_version
reconnect
report_mode
diff --git a/ext/mysqli/tests/mysqli_class_mysqli_interface.phpt b/ext/mysqli/tests/mysqli_class_mysqli_interface.phpt
index 48706fcf6e..d0d858b9de 100644
--- a/ext/mysqli/tests/mysqli_class_mysqli_interface.phpt
+++ b/ext/mysqli/tests/mysqli_class_mysqli_interface.phpt
@@ -92,7 +92,7 @@ require_once('skipifconnectfailure.inc');
printf("\nClass variables:\n");
- $expected_class_variables = $expected_object_variables = array(
+ $expected_class_variables = [
"affected_rows" => true,
"client_info" => true,
"client_version" => true,
@@ -110,10 +110,10 @@ require_once('skipifconnectfailure.inc');
"sqlstate" => true,
"thread_id" => true,
"warning_count" => true,
- );
+ "error_list" => true,
+ ];
- $expected_class_variables["error_list"] = true;
- $expected_object_variables["error_list"] = true;
+ $expected_object_variables = [];
$variables = get_class_vars(get_class($mysqli));
foreach ($variables as $var => $v) {
diff --git a/ext/mysqli/tests/mysqli_class_mysqli_properties_no_conn.phpt b/ext/mysqli/tests/mysqli_class_mysqli_properties_no_conn.phpt
index d44b349557..b04fb93e9c 100644
--- a/ext/mysqli/tests/mysqli_class_mysqli_properties_no_conn.phpt
+++ b/ext/mysqli/tests/mysqli_class_mysqli_properties_no_conn.phpt
@@ -257,24 +257,6 @@ mysqli object is already closed
mysqli object is already closed
Object variables:
-Property access is not allowed yet
-client_info = '%s'
-client_version = '%s'
-connect_errno = '%s'
-connect_error = ''%s'
-mysqli object is already closed
-mysqli object is already closed
-Property access is not allowed yet
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
Magic, magic properties:
mysqli object is already closed
@@ -339,24 +321,6 @@ mysqli object is already closed
mysqli object is already closed
Object variables:
-Property access is not allowed yet
-client_info = '%s'
-client_version = '%s'
-connect_errno = '%s'
-connect_error = '%s'
-mysqli object is already closed
-mysqli object is already closed
-Property access is not allowed yet
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
-mysqli object is already closed
Magic, magic properties:
mysqli object is already closed
diff --git a/ext/mysqli/tests/mysqli_class_mysqli_result_interface.phpt b/ext/mysqli/tests/mysqli_class_mysqli_result_interface.phpt
index 4837a5f695..27656417e5 100644
--- a/ext/mysqli/tests/mysqli_class_mysqli_result_interface.phpt
+++ b/ext/mysqli/tests/mysqli_class_mysqli_result_interface.phpt
@@ -162,11 +162,6 @@ num_rows
type
Object variables:
-current_field
-field_count
-lengths
-num_rows
-type
Magic, magic properties:
mysqli_result->current_field = '0'/integer ('0'/integer)
diff --git a/ext/mysqli/tests/mysqli_class_mysqli_stmt_interface.phpt b/ext/mysqli/tests/mysqli_class_mysqli_stmt_interface.phpt
index 393e06ebaa..b10877a285 100644
--- a/ext/mysqli/tests/mysqli_class_mysqli_stmt_interface.phpt
+++ b/ext/mysqli/tests/mysqli_class_mysqli_stmt_interface.phpt
@@ -153,16 +153,6 @@ param_count
sqlstate
Object variables:
-affected_rows
-insert_id
-num_rows
-param_count
-field_count
-errno
-error
-error_list
-sqlstate
-id
Magic, magic properties:
mysqli_stmt object is not fully initialized