Review parameter names in ext/pspell

Closes GH-6257

2 files changed, 40 insertions, 36 deletions

diff --git a/ext/pspell/pspell.stub.php b/ext/pspell/pspell.stub.php
index 03363f46b8..241e510471 100644
--- a/ext/pspell/pspell.stub.php
+++ b/ext/pspell/pspell.stub.php
@@ -4,38 +4,45 @@
 
 function pspell_new(string $language, string $spelling = "", string $jargon = "", string $encoding = "", int $mode = 0): int|false {}
 
-function pspell_new_personal(string $personal, string $language, string $spelling = "", string $jargon = "", string $encoding = "", int $mode = 0): int|false {}
+function pspell_new_personal(
+    string $filename,
+    string $language,
+    string $spelling = "",
+    string $jargon = "",
+    string $encoding = "",
+    int $mode = 0
+): int|false {}
 
 function pspell_new_config(int $config): int|false {}
 
-function pspell_check(int $pspell, string $word): bool {}
+function pspell_check(int $dictionary, string $word): bool {}
 
-function pspell_suggest(int $pspell, string $word): array|false {}
+function pspell_suggest(int $dictionary, string $word): array|false {}
 
-function pspell_store_replacement(int $pspell, string $misspell, string $correct): bool {}
+function pspell_store_replacement(int $dictionary, string $misspelled, string $correct): bool {}
 
-function pspell_add_to_personal(int $pspell, string $word): bool {}
+function pspell_add_to_personal(int $dictionary, string $word): bool {}
 
-function pspell_add_to_session(int $pspell, string $word): bool {}
+function pspell_add_to_session(int $dictionary, string $word): bool {}
 
-function pspell_clear_session(int $pspell): bool {}
+function pspell_clear_session(int $dictionary): bool {}
 
-function pspell_save_wordlist(int $pspell): bool {}
+function pspell_save_wordlist(int $dictionary): bool {}
 
 function pspell_config_create(string $language, string $spelling = "", string $jargon = "", string $encoding = ""): int {}
 
-function pspell_config_runtogether(int $conf, bool $runtogether): bool {}
+function pspell_config_runtogether(int $config, bool $allow): bool {}
 
-function pspell_config_mode(int $conf, int $mode): bool {}
+function pspell_config_mode(int $config, int $mode): bool {}
 
-function pspell_config_ignore(int $conf, int $ignore): bool {}
+function pspell_config_ignore(int $config, int $min_length): bool {}
 
-function pspell_config_personal(int $conf, string $personal): bool {}
+function pspell_config_personal(int $config, string $filename): bool {}
 
-function pspell_config_dict_dir(int $conf, string $directory): bool {}
+function pspell_config_dict_dir(int $config, string $directory): bool {}
 
-function pspell_config_data_dir(int $conf, string $directory): bool {}
+function pspell_config_data_dir(int $config, string $directory): bool {}
 
-function pspell_config_repl(int $conf, string $repl): bool {}
+function pspell_config_repl(int $config, string $filename): bool {}
 
-function pspell_config_save_repl(int $conf, bool $save): bool {}
+function pspell_config_save_repl(int $dictionary, bool $save): bool {}
diff --git a/ext/pspell/pspell_arginfo.h b/ext/pspell/pspell_arginfo.h
index 4a009dec12..93fd069e9e 100644
--- a/ext/pspell/pspell_arginfo.h
+++ b/ext/pspell/pspell_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 77f9effa6d246cf2b8da121d219462cce8a99918 */
+ * Stub hash: 9a6f7791175f73d92c3b92da45f282805ea09a1c */
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_pspell_new, 0, 1, MAY_BE_LONG|MAY_BE_FALSE)
 	ZEND_ARG_TYPE_INFO(0, language, IS_STRING, 0)
@@ -10,7 +10,7 @@ ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_pspell_new, 0, 1, MAY_BE_LONG|MA
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_pspell_new_personal, 0, 2, MAY_BE_LONG|MAY_BE_FALSE)
-	ZEND_ARG_TYPE_INFO(0, personal, IS_STRING, 0)
+	ZEND_ARG_TYPE_INFO(0, filename, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO(0, language, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, spelling, IS_STRING, 0, "\"\"")
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, jargon, IS_STRING, 0, "\"\"")
@@ -23,18 +23,18 @@ ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_pspell_new_config, 0, 1, MAY_BE_
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_pspell_check, 0, 2, _IS_BOOL, 0)
-	ZEND_ARG_TYPE_INFO(0, pspell, IS_LONG, 0)
+	ZEND_ARG_TYPE_INFO(0, dictionary, IS_LONG, 0)
 	ZEND_ARG_TYPE_INFO(0, word, IS_STRING, 0)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_MASK_EX(arginfo_pspell_suggest, 0, 2, MAY_BE_ARRAY|MAY_BE_FALSE)
-	ZEND_ARG_TYPE_INFO(0, pspell, IS_LONG, 0)
+	ZEND_ARG_TYPE_INFO(0, dictionary, IS_LONG, 0)
 	ZEND_ARG_TYPE_INFO(0, word, IS_STRING, 0)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_pspell_store_replacement, 0, 3, _IS_BOOL, 0)
-	ZEND_ARG_TYPE_INFO(0, pspell, IS_LONG, 0)
-	ZEND_ARG_TYPE_INFO(0, misspell, IS_STRING, 0)
+	ZEND_ARG_TYPE_INFO(0, dictionary, IS_LONG, 0)
+	ZEND_ARG_TYPE_INFO(0, misspelled, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO(0, correct, IS_STRING, 0)
 ZEND_END_ARG_INFO()
 
@@ -43,7 +43,7 @@ ZEND_END_ARG_INFO()
 #define arginfo_pspell_add_to_session arginfo_pspell_check
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_pspell_clear_session, 0, 1, _IS_BOOL, 0)
-	ZEND_ARG_TYPE_INFO(0, pspell, IS_LONG, 0)
+	ZEND_ARG_TYPE_INFO(0, dictionary, IS_LONG, 0)
 ZEND_END_ARG_INFO()
 
 #define arginfo_pspell_save_wordlist arginfo_pspell_clear_session
@@ -56,39 +56,36 @@ ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_pspell_config_create, 0, 1, IS_L
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_pspell_config_runtogether, 0, 2, _IS_BOOL, 0)
-	ZEND_ARG_TYPE_INFO(0, conf, IS_LONG, 0)
-	ZEND_ARG_TYPE_INFO(0, runtogether, _IS_BOOL, 0)
+	ZEND_ARG_TYPE_INFO(0, config, IS_LONG, 0)
+	ZEND_ARG_TYPE_INFO(0, allow, _IS_BOOL, 0)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_pspell_config_mode, 0, 2, _IS_BOOL, 0)
-	ZEND_ARG_TYPE_INFO(0, conf, IS_LONG, 0)
+	ZEND_ARG_TYPE_INFO(0, config, IS_LONG, 0)
 	ZEND_ARG_TYPE_INFO(0, mode, IS_LONG, 0)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_pspell_config_ignore, 0, 2, _IS_BOOL, 0)
-	ZEND_ARG_TYPE_INFO(0, conf, IS_LONG, 0)
-	ZEND_ARG_TYPE_INFO(0, ignore, IS_LONG, 0)
+	ZEND_ARG_TYPE_INFO(0, config, IS_LONG, 0)
+	ZEND_ARG_TYPE_INFO(0, min_length, IS_LONG, 0)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_pspell_config_personal, 0, 2, _IS_BOOL, 0)
-	ZEND_ARG_TYPE_INFO(0, conf, IS_LONG, 0)
-	ZEND_ARG_TYPE_INFO(0, personal, IS_STRING, 0)
+	ZEND_ARG_TYPE_INFO(0, config, IS_LONG, 0)
+	ZEND_ARG_TYPE_INFO(0, filename, IS_STRING, 0)
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_pspell_config_dict_dir, 0, 2, _IS_BOOL, 0)
-	ZEND_ARG_TYPE_INFO(0, conf, IS_LONG, 0)
+	ZEND_ARG_TYPE_INFO(0, config, IS_LONG, 0)
 	ZEND_ARG_TYPE_INFO(0, directory, IS_STRING, 0)
 ZEND_END_ARG_INFO()
 
 #define arginfo_pspell_config_data_dir arginfo_pspell_config_dict_dir
 
-ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_pspell_config_repl, 0, 2, _IS_BOOL, 0)
-	ZEND_ARG_TYPE_INFO(0, conf, IS_LONG, 0)
-	ZEND_ARG_TYPE_INFO(0, repl, IS_STRING, 0)
-ZEND_END_ARG_INFO()
+#define arginfo_pspell_config_repl arginfo_pspell_config_personal
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_pspell_config_save_repl, 0, 2, _IS_BOOL, 0)
-	ZEND_ARG_TYPE_INFO(0, conf, IS_LONG, 0)
+	ZEND_ARG_TYPE_INFO(0, dictionary, IS_LONG, 0)
 	ZEND_ARG_TYPE_INFO(0, save, _IS_BOOL, 0)
 ZEND_END_ARG_INFO()