summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNikita Popov <nikita.ppv@gmail.com>2020-04-14 12:02:04 +0200
committerNikita Popov <nikita.ppv@gmail.com>2020-04-14 12:02:22 +0200
commit56d30bb35a509ea195f0ffe287f483880047820f (patch)
tree81aadd364a0c1d9c629f2c41ebe307061485fe8e
parent1c469adb8b208e643086186a5e60a1df59ca2582 (diff)
parentef56b2c977cac5e47e0ba4960b8305078ded87be (diff)
downloadphp-git-56d30bb35a509ea195f0ffe287f483880047820f.tar.gz
Merge branch 'PHP-7.4'
* PHP-7.4: Fixed bug #79468
-rw-r--r--ext/standard/tests/filters/bug79468.phpt21
-rw-r--r--main/streams/streams.c6
2 files changed, 27 insertions, 0 deletions
diff --git a/ext/standard/tests/filters/bug79468.phpt b/ext/standard/tests/filters/bug79468.phpt
new file mode 100644
index 0000000000..0373f31710
--- /dev/null
+++ b/ext/standard/tests/filters/bug79468.phpt
@@ -0,0 +1,21 @@
+--TEST--
+Bug #79468 SIGSEGV when closing stream handle with a stream filter appended
+--SKIPIF--
+<?php
+$filters = stream_get_filters();
+if(! in_array( "string.rot13", $filters )) die( "skip rot13 filter not available." );
+?>
+--FILE--
+<?php
+$fp = fopen('php://temp', 'rb');
+$rot13_filter = stream_filter_append($fp, "string.rot13", STREAM_FILTER_WRITE);
+fwrite($fp, "This is ");
+fclose($fp);
+try {
+ stream_filter_remove($rot13_filter);
+} catch (\Throwable $e) {
+ var_dump($e->getMessage());
+}
+?>
+--EXPECT--
+string(79) "stream_filter_remove(): supplied resource is not a valid stream filter resource"
diff --git a/main/streams/streams.c b/main/streams/streams.c
index 8bce4a7db2..9762fa90e8 100644
--- a/main/streams/streams.c
+++ b/main/streams/streams.c
@@ -485,9 +485,15 @@ fprintf(stderr, "stream_free: %s:%p[%s] preserve_handle=%d release_cast=%d remov
if (close_options & PHP_STREAM_FREE_RELEASE_STREAM) {
while (stream->readfilters.head) {
+ if (stream->readfilters.head->res != NULL) {
+ zend_list_close(stream->readfilters.head->res);
+ }
php_stream_filter_remove(stream->readfilters.head, 1);
}
while (stream->writefilters.head) {
+ if (stream->writefilters.head->res != NULL) {
+ zend_list_close(stream->writefilters.head->res);
+ }
php_stream_filter_remove(stream->writefilters.head, 1);
}