diff options
| author | Kalle Sommer Nielsen <kalle@php.net> | 2016-11-19 10:10:48 +0100 |
|---|---|---|
| committer | Kalle Sommer Nielsen <kalle@php.net> | 2016-11-19 10:10:48 +0100 |
| commit | 673bbff0e508ea7ad89a9772f8a48dbe92ecc591 (patch) | |
| tree | 158fbe51c9791a05e26d797e296a7b3079ecba57 | |
| parent | ddf95667c432a3088fc6d176f4d9d719baaca20c (diff) | |
| download | php-git-673bbff0e508ea7ad89a9772f8a48dbe92ecc591.tar.gz | |
Updated the comment regarding what priority modes that are left out for the nice() implementation on Windows
| -rw-r--r-- | win32/nice.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/win32/nice.c b/win32/nice.c index 202a4d8e35..d2487074fc 100644 --- a/win32/nice.c +++ b/win32/nice.c @@ -47,7 +47,18 @@ * This is applied to the main process, not per thread, although this could * be implemented using SetThreadPriority() at one point. * - * Note, it is intended that some priority classes are left out. + * Note, the following priority classes are left out with intention: + * + * . REALTIME_PRIORITY_CLASS + * Realtime priority class requires special system permissions to set, and + * can be dangerous in certain cases. + * + * . PROCESS_MODE_BACKGROUND_BEGIN + * . PROCESS_MODE_BACKGROUND_END + * Process mode is not covered because it can easily forgotten to be changed + * back and can cause unforseen side effects that is hard to debug. Besides + * that, these do generally not really fit into making a Windows somewhat + * compatible nice() function. */ PHPAPI int nice(zend_long p) |