diff options
| author | Antony Dovgal <tony2001@php.net> | 2008-01-23 12:09:52 +0000 |
|---|---|---|
| committer | Antony Dovgal <tony2001@php.net> | 2008-01-23 12:09:52 +0000 |
| commit | 67c8d8d95ede1fcbf71ed7f9fdc7b43ce2b17f64 (patch) | |
| tree | 47f9129190e5985553d320b64c263164c6dfe6cc | |
| parent | d008f576b0327f5fbae8a1a646300fa640b9bdbd (diff) | |
| download | php-git-67c8d8d95ede1fcbf71ed7f9fdc7b43ce2b17f64.tar.gz | |
MFH: fix #43559 (array_merge_recursive() doesn't behave as expected with duplicate NULL values)
patch by Felipe
| -rw-r--r-- | ext/standard/array.c | 14 | ||||
| -rw-r--r-- | ext/standard/tests/array/array_merge_recursive_variation5.phpt | 4 |
2 files changed, 15 insertions, 3 deletions
diff --git a/ext/standard/array.c b/ext/standard/array.c index c7f2c3a30a..9283de508a 100644 --- a/ext/standard/array.c +++ b/ext/standard/array.c @@ -2197,8 +2197,18 @@ PHPAPI int php_array_merge(HashTable *dest, HashTable *src, int recursive TSRMLS SEPARATE_ZVAL(dest_entry); SEPARATE_ZVAL(src_entry); - convert_to_array_ex(dest_entry); - convert_to_array_ex(src_entry); + if (Z_TYPE_PP(dest_entry) == IS_NULL) { + convert_to_array_ex(dest_entry); + add_next_index_null(*dest_entry); + } else { + convert_to_array_ex(dest_entry); + } + if (Z_TYPE_PP(src_entry) == IS_NULL) { + convert_to_array_ex(src_entry); + add_next_index_null(*src_entry); + } else { + convert_to_array_ex(src_entry); + } if (thash) { thash->nApplyCount++; } diff --git a/ext/standard/tests/array/array_merge_recursive_variation5.phpt b/ext/standard/tests/array/array_merge_recursive_variation5.phpt index 6a6a50140f..3b251220ea 100644 --- a/ext/standard/tests/array/array_merge_recursive_variation5.phpt +++ b/ext/standard/tests/array/array_merge_recursive_variation5.phpt @@ -374,8 +374,10 @@ array(8) { object(classA)#%d (0) { } ["string"]=> - array(1) { + array(2) { [0]=> + NULL + [1]=> string(5) "hello" } ["resource"]=> |