summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIlia Alshanetsky <iliaa@php.net>2004-05-10 22:13:08 +0000
committerIlia Alshanetsky <iliaa@php.net>2004-05-10 22:13:08 +0000
commit97d91c76569ef95b9644a77bbc41204f7ff0a01b (patch)
tree82c794e758ca42f53a8ba6a77dd3f397fd1a3584
parentd3b364fdc77ee991f2dd35822ca00714ebcbb4dd (diff)
downloadphp-git-97d91c76569ef95b9644a77bbc41204f7ff0a01b.tar.gz
Fixed crash inside cpdf_place_inline_image() when working with truecolor
images.
-rw-r--r--ext/cpdf/cpdf.c26
1 files changed, 20 insertions, 6 deletions
diff --git a/ext/cpdf/cpdf.c b/ext/cpdf/cpdf.c
index 17663ca7a2..f6162b2efc 100644
--- a/ext/cpdf/cpdf.c
+++ b/ext/cpdf/cpdf.c
@@ -2056,16 +2056,30 @@ PHP_FUNCTION(cpdf_place_inline_image)
}
count = 3 * im->sx * im->sy;
- if(NULL == (buffer = (unsigned char *) emalloc(count)))
- RETURN_FALSE;
+ buffer = (unsigned char *) safe_emalloc(3 * im->sx, im->sy, 0);
ptr = buffer;
for(i=0; i<im->sy; i++) {
for(j=0; j<im->sx; j++) {
- color = im->pixels[i][j];
- *ptr++ = im->red[color];
- *ptr++ = im->green[color];
- *ptr++ = im->blue[color];
+#if HAVE_LIBGD20
+ if(gdImageTrueColor(im)) {
+ if (im->tpixels && gdImageBoundsSafe(im, j, i)) {
+ color = gdImageTrueColorPixel(im, j, i);
+ *ptr++ = (color >> 16) & 0xFF;
+ *ptr++ = (color >> 8) & 0xFF;
+ *ptr++ = color & 0xFF;
+ }
+ } else {
+#endif
+ if (im->pixels && gdImageBoundsSafe(im, j, i)) {
+ color = im->pixels[i][j];
+ *ptr++ = im->red[color];
+ *ptr++ = im->green[color];
+ *ptr++ = im->blue[color];
+ }
+#if HAVE_LIBGD20
+ }
+#endif
}
}