diff options
author | Gustavo André dos Santos Lopes <cataphract@php.net> | 2012-04-07 16:32:19 +0100 |
---|---|---|
committer | Johannes Schlüter <johannes@php.net> | 2012-04-12 11:04:20 +0200 |
commit | a4e6394a06fb11f80426e94874d0702cf5235726 (patch) | |
tree | f7ede050111f301110958b15e6e786e7b0dff2f5 | |
parent | 9ad0b878d91064d78bcd093a4660ea2bf99b03fb (diff) | |
download | php-git-a4e6394a06fb11f80426e94874d0702cf5235726.tar.gz |
Fixed bug in new stream_get_line() when using NUL as a delimiter.
This is the issue Derick spotted a few days ago..
-rw-r--r-- | ext/standard/tests/streams/stream_get_line_NUL_delimiter.phpt | 27 | ||||
-rwxr-xr-x | main/streams/streams.c | 4 |
2 files changed, 29 insertions, 2 deletions
diff --git a/ext/standard/tests/streams/stream_get_line_NUL_delimiter.phpt b/ext/standard/tests/streams/stream_get_line_NUL_delimiter.phpt new file mode 100644 index 0000000000..32756d7618 --- /dev/null +++ b/ext/standard/tests/streams/stream_get_line_NUL_delimiter.phpt @@ -0,0 +1,27 @@ +--TEST-- +Bug #60455: stream_get_line and \0 as a delimiter +--FILE-- +<?php +class TestStream { + private $s = 0; + function stream_open($path, $mode, $options, &$opened_path) { + return true; + } + function stream_read($count) { + if ($this->s++ == 0) + return "a\0"; + + return ""; + } + function stream_eof() { + return $this->s >= 2; + } + +} + +stream_wrapper_register("test", "TestStream"); + +$f = fopen("test://", "r"); +var_dump(stream_get_line($f, 100, "\0")); +--EXPECT-- +string(1) "a" diff --git a/main/streams/streams.c b/main/streams/streams.c index 639ea075a0..116c0aa045 100755 --- a/main/streams/streams.c +++ b/main/streams/streams.c @@ -957,8 +957,8 @@ PHPAPI char *php_stream_get_record(php_stream *stream, size_t maxlen, size_t *re char *ret_buf, /* returned buffer */ *found_delim = NULL; size_t buffered_len, - tent_ret_len; /* tentative returned length*/ - int has_delim = delim_len > 0 && delim[0] != '\0'; + tent_ret_len; /* tentative returned length */ + int has_delim = delim_len > 0; if (maxlen == 0) { return NULL; |