diff options
| author | Wez Furlong <wez@php.net> | 2004-10-26 09:28:34 +0000 |
|---|---|---|
| committer | Wez Furlong <wez@php.net> | 2004-10-26 09:28:34 +0000 |
| commit | af9a8dfaa38a590558a7523330466c7a53aa3ba3 (patch) | |
| tree | cca7473be392b89c98fb2768373924311fb3ea06 | |
| parent | 01ba76a2ed00d3500042d1a0d7f71c6b4e8b62a0 (diff) | |
| download | php-git-af9a8dfaa38a590558a7523330466c7a53aa3ba3.tar.gz | |
Fix for Bug #29418 (double free when openssl_csr_new fails).
Also hook up MSHUTDOWN function which appears to have never been enabled.
Patch by Kamesh Jayachandran
| -rw-r--r-- | ext/openssl/openssl.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/ext/openssl/openssl.c b/ext/openssl/openssl.c index 3d8665b623..091b14ff77 100644 --- a/ext/openssl/openssl.c +++ b/ext/openssl/openssl.c @@ -135,7 +135,7 @@ zend_module_entry openssl_module_entry = { "openssl", openssl_functions, PHP_MINIT(openssl), - NULL, + PHP_MSHUTDOWN(openssl), NULL, NULL, PHP_MINFO(openssl), @@ -1675,6 +1675,12 @@ PHP_FUNCTION(openssl_csr_new) } } } + else { + if (!we_made_the_key) { + /* if we have not made the key we are not supposed to zap it by calling dispose! */ + req.priv_key = NULL; + } + } } } } |