diff options
| author | Ilia Alshanetsky <iliaa@php.net> | 2007-04-24 13:54:59 +0000 |
|---|---|---|
| committer | Ilia Alshanetsky <iliaa@php.net> | 2007-04-24 13:54:59 +0000 |
| commit | bc9f8f582cefd55140d00d731949502f1e66f9b9 (patch) | |
| tree | d6fc77f3c6c05ef2815c6e4825dc4de693d5bad8 | |
| parent | c8925ba49306bd9e623770f6ff055ae6639776a0 (diff) | |
| download | php-git-bc9f8f582cefd55140d00d731949502f1e66f9b9.tar.gz | |
Fixed bug #41175 (addAttribute() fails to add an attribute with an empty
value).
| -rw-r--r-- | NEWS | 2 | ||||
| -rw-r--r-- | ext/simplexml/simplexml.c | 2 | ||||
| -rw-r--r-- | ext/simplexml/tests/bug41175.phpt | 16 |
3 files changed, 19 insertions, 1 deletions
@@ -4,6 +4,8 @@ PHP NEWS - Fixed commandline handling fro CLI and CGI. (Marcus, Johannes) - Upgraded SQLite 3 to version 3.3.16 (Ilia) - Updated timezone database to version 2007.5. (Derick) +- Fixed bug #41175 (addAttribute() fails to add an attribute with an empty + value). (Ilia) - Fixed bug #41159 (mysql_pconnect() hash does not account for connect flags). (Ilia) - Fixed bug #41121 (range() overflow handling for large numbers on 32bit diff --git a/ext/simplexml/simplexml.c b/ext/simplexml/simplexml.c index 2c919ea24f..0b0f9ff54b 100644 --- a/ext/simplexml/simplexml.c +++ b/ext/simplexml/simplexml.c @@ -1542,7 +1542,7 @@ SXE_METHOD(addAttribute) return; } - if (qname_len == 0 || value_len == 0) { + if (qname_len == 0) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "Attribute name and value are required"); return; } diff --git a/ext/simplexml/tests/bug41175.phpt b/ext/simplexml/tests/bug41175.phpt new file mode 100644 index 0000000000..51181d29c0 --- /dev/null +++ b/ext/simplexml/tests/bug41175.phpt @@ -0,0 +1,16 @@ +--TEST-- +Bug #41175 (addAttribute() fails to add an attribute with an empty value) +--FILE-- +<?php + +$xml = new SimpleXmlElement("<img></img>"); +$xml->addAttribute("src", "foo"); +$xml->addAttribute("alt", ""); +echo $xml->asXML(); + +echo "Done\n"; +?> +--EXPECT-- +<?xml version="1.0"?> +<img src="foo" alt=""/> +Done
\ No newline at end of file |