summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTjerk Meesters <datibbaw@php.net>2014-07-15 20:28:16 +0800
committerStanislav Malyshev <stas@php.net>2014-11-30 22:42:13 -0800
commitbfe7c6988fd128352c3ec6a5b95ac9c1fbb5fe06 (patch)
tree41988a83a9507d8e2dcf57a0e14ebd11047279d9
parent904dca6392f44dfea7d2eba4b688903fe06395f7 (diff)
downloadphp-git-bfe7c6988fd128352c3ec6a5b95ac9c1fbb5fe06.tar.gz
Added more useful warning messages
-rw-r--r--ext/standard/dns.c23
1 files changed, 17 insertions, 6 deletions
diff --git a/ext/standard/dns.c b/ext/standard/dns.c
index cdec56bf14..a673974705 100644
--- a/ext/standard/dns.c
+++ b/ext/standard/dns.c
@@ -897,13 +897,24 @@ PHP_FUNCTION(dns_get_record)
if (n < 0) {
php_dns_free_handle(handle);
- if (h_errno == NO_DATA || h_errno == HOST_NOT_FOUND) {
- continue;
- } else {
- php_error_docref(NULL TSRMLS_CC, E_WARNING, "DNS Query failed");
- zval_dtor(return_value);
- RETURN_FALSE;
+ switch (h_errno) {
+ case NO_DATA:
+ case HOST_NOT_FOUND:
+ continue;
+
+ case NO_RECOVERY:
+ php_error_docref(NULL TSRMLS_CC, E_WARNING, "An unexpected server failure occurred.");
+ break;
+
+ case TRY_AGAIN:
+ php_error_docref(NULL TSRMLS_CC, E_WARNING, "A temporary server error occurred.");
+ break;
+
+ default:
+ php_error_docref(NULL TSRMLS_CC, E_WARNING, "DNS Query failed");
}
+ zval_dtor(return_value);
+ RETURN_FALSE;
}
cp = answer.qb2 + HFIXEDSZ;