diff options
author | Nikita Popov <nikita.ppv@gmail.com> | 2018-02-04 23:27:31 +0100 |
---|---|---|
committer | Nikita Popov <nikita.ppv@gmail.com> | 2018-02-04 23:27:51 +0100 |
commit | fc23452cbf4a825b36f993ef59badb6cb075a22b (patch) | |
tree | 1555293338c875084988a23c2034ff396ffba093 | |
parent | b4dff68379d8625f4895e74841683205d3fdd9ae (diff) | |
download | php-git-fc23452cbf4a825b36f993ef59badb6cb075a22b.tar.gz |
Adjust manual zpp-like error message implementations
This should also use int/bool.
-rw-r--r-- | ext/ftp/php_ftp.c | 6 | ||||
-rw-r--r-- | ext/standard/filestat.c | 8 | ||||
-rw-r--r-- | ext/standard/tests/file/chgrp.phpt | 2 | ||||
-rw-r--r-- | ext/standard/tests/file/chown.phpt | 2 |
4 files changed, 9 insertions, 9 deletions
diff --git a/ext/ftp/php_ftp.c b/ext/ftp/php_ftp.c index 5aad7b000f..c6309676ba 100644 --- a/ext/ftp/php_ftp.c +++ b/ext/ftp/php_ftp.c @@ -1543,7 +1543,7 @@ PHP_FUNCTION(ftp_set_option) switch (option) { case PHP_FTP_OPT_TIMEOUT_SEC: if (Z_TYPE_P(z_value) != IS_LONG) { - php_error_docref(NULL, E_WARNING, "Option TIMEOUT_SEC expects value of type long, %s given", + php_error_docref(NULL, E_WARNING, "Option TIMEOUT_SEC expects value of type int, %s given", zend_zval_type_name(z_value)); RETURN_FALSE; } @@ -1556,7 +1556,7 @@ PHP_FUNCTION(ftp_set_option) break; case PHP_FTP_OPT_AUTOSEEK: if (Z_TYPE_P(z_value) != IS_TRUE && Z_TYPE_P(z_value) != IS_FALSE) { - php_error_docref(NULL, E_WARNING, "Option AUTOSEEK expects value of type boolean, %s given", + php_error_docref(NULL, E_WARNING, "Option AUTOSEEK expects value of type bool, %s given", zend_zval_type_name(z_value)); RETURN_FALSE; } @@ -1565,7 +1565,7 @@ PHP_FUNCTION(ftp_set_option) break; case PHP_FTP_OPT_USEPASVADDRESS: if (Z_TYPE_P(z_value) != IS_TRUE && Z_TYPE_P(z_value) != IS_FALSE) { - php_error_docref(NULL, E_WARNING, "Option USEPASVADDRESS expects value of type boolean, %s given", + php_error_docref(NULL, E_WARNING, "Option USEPASVADDRESS expects value of type bool, %s given", zend_zval_type_name(z_value)); RETURN_FALSE; } diff --git a/ext/standard/filestat.c b/ext/standard/filestat.c index 6af241fa64..a405f0dfdc 100644 --- a/ext/standard/filestat.c +++ b/ext/standard/filestat.c @@ -354,7 +354,7 @@ static void php_do_chgrp(INTERNAL_FUNCTION_PARAMETERS, int do_lchgrp) /* {{{ */ option = PHP_STREAM_META_GROUP_NAME; value = Z_STRVAL_P(group); } else { - php_error_docref(NULL, E_WARNING, "parameter 2 should be string or integer, %s given", zend_zval_type_name(group)); + php_error_docref(NULL, E_WARNING, "parameter 2 should be string or int, %s given", zend_zval_type_name(group)); RETURN_FALSE; } if(wrapper->wops->stream_metadata(wrapper, filename, option, value, NULL)) { @@ -383,7 +383,7 @@ static void php_do_chgrp(INTERNAL_FUNCTION_PARAMETERS, int do_lchgrp) /* {{{ */ RETURN_FALSE; } } else { - php_error_docref(NULL, E_WARNING, "parameter 2 should be string or integer, %s given", zend_zval_type_name(group)); + php_error_docref(NULL, E_WARNING, "parameter 2 should be string or int, %s given", zend_zval_type_name(group)); RETURN_FALSE; } @@ -490,7 +490,7 @@ static void php_do_chown(INTERNAL_FUNCTION_PARAMETERS, int do_lchown) /* {{{ */ option = PHP_STREAM_META_OWNER_NAME; value = Z_STRVAL_P(user); } else { - php_error_docref(NULL, E_WARNING, "parameter 2 should be string or integer, %s given", zend_zval_type_name(user)); + php_error_docref(NULL, E_WARNING, "parameter 2 should be string or int, %s given", zend_zval_type_name(user)); RETURN_FALSE; } if(wrapper->wops->stream_metadata(wrapper, filename, option, value, NULL)) { @@ -520,7 +520,7 @@ static void php_do_chown(INTERNAL_FUNCTION_PARAMETERS, int do_lchown) /* {{{ */ RETURN_FALSE; } } else { - php_error_docref(NULL, E_WARNING, "parameter 2 should be string or integer, %s given", zend_zval_type_name(user)); + php_error_docref(NULL, E_WARNING, "parameter 2 should be string or int, %s given", zend_zval_type_name(user)); RETURN_FALSE; } diff --git a/ext/standard/tests/file/chgrp.phpt b/ext/standard/tests/file/chgrp.phpt index 9c85f5c835..03ea24141b 100644 --- a/ext/standard/tests/file/chgrp.phpt +++ b/ext/standard/tests/file/chgrp.phpt @@ -11,5 +11,5 @@ chgrp("sjhgfskhagkfdgskjfhgskfsdgfkdsajf", NULL); echo "ALIVE\n"; ?> --EXPECTF-- -Warning: chgrp(): parameter 2 should be string or integer, null given in %schgrp.php on line 2 +Warning: chgrp(): parameter 2 should be string or int, null given in %schgrp.php on line 2 ALIVE diff --git a/ext/standard/tests/file/chown.phpt b/ext/standard/tests/file/chown.phpt index 9075d3dc33..049073e7a0 100644 --- a/ext/standard/tests/file/chown.phpt +++ b/ext/standard/tests/file/chown.phpt @@ -11,5 +11,5 @@ chown("sjhgfskhagkfdgskjfhgskfsdgfkdsajf", NULL); echo "ALIVE\n"; ?> --EXPECTF-- -Warning: chown(): parameter 2 should be string or integer, null given in %schown.php on line %d +Warning: chown(): parameter 2 should be string or int, null given in %schown.php on line %d ALIVE |