summaryrefslogtreecommitdiff
path: root/Zend/zend_execute_API.c
diff options
context:
space:
mode:
authorDmitry Stogov <dmitry@zend.com>2018-06-01 11:58:57 +0300
committerDmitry Stogov <dmitry@zend.com>2018-06-01 11:58:57 +0300
commit0b90cf85a6ace22abd0f9f86d5015a5b6db92387 (patch)
treee01be0712ad1d7dbcd61c81ce03b9544a69e4972 /Zend/zend_execute_API.c
parent9e0f131d2b0e8bf98859c12104a7b0cd8951c135 (diff)
downloadphp-git-0b90cf85a6ace22abd0f9f86d5015a5b6db92387.tar.gz
Removed "dead" code (zend_hash_update() never fails)
Diffstat (limited to 'Zend/zend_execute_API.c')
-rw-r--r--Zend/zend_execute_API.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/Zend/zend_execute_API.c b/Zend/zend_execute_API.c
index 4f394df21a..e7a96af743 100644
--- a/Zend/zend_execute_API.c
+++ b/Zend/zend_execute_API.c
@@ -1606,11 +1606,13 @@ ZEND_API int zend_set_local_var(zend_string *name, zval *value, int force) /* {{
if (force) {
zend_array *symbol_table = zend_rebuild_symbol_table();
if (symbol_table) {
- return zend_hash_update(symbol_table, name, value) ? SUCCESS : FAILURE;
+ zend_hash_update(symbol_table, name, value);
+ return SUCCESS;
}
}
} else {
- return (zend_hash_update_ind(execute_data->symbol_table, name, value) != NULL) ? SUCCESS : FAILURE;
+ zend_hash_update_ind(execute_data->symbol_table, name, value);
+ return SUCCESS;
}
}
return FAILURE;
@@ -1648,11 +1650,13 @@ ZEND_API int zend_set_local_var_str(const char *name, size_t len, zval *value, i
if (force) {
zend_array *symbol_table = zend_rebuild_symbol_table();
if (symbol_table) {
- return zend_hash_str_update(symbol_table, name, len, value) ? SUCCESS : FAILURE;
+ zend_hash_str_update(symbol_table, name, len, value);
+ return SUCCESS;
}
}
} else {
- return (zend_hash_str_update_ind(execute_data->symbol_table, name, len, value) != NULL) ? SUCCESS : FAILURE;
+ zend_hash_str_update_ind(execute_data->symbol_table, name, len, value);
+ return SUCCESS;
}
}
return FAILURE;