summaryrefslogtreecommitdiff
path: root/Zend/zend_execute_API.c
diff options
context:
space:
mode:
authorArnout Boks <arnoutboks@gmail.com>2017-01-25 21:09:03 +0100
committerJoe Watkins <krakjoe@php.net>2017-01-25 20:59:25 +0000
commit721a189742acc6fb6c2c6d98ce86eebe4e34d42a (patch)
treed21a5f709c4a12b653ca26a842df0a10465a5460 /Zend/zend_execute_API.c
parent737ee0661c15f5eb812467c3e10ee1f784691be9 (diff)
downloadphp-git-721a189742acc6fb6c2c6d98ce86eebe4e34d42a.tar.gz
Fix bug #54382 (getAttributeNodeNS doesn't get xmlns* attributes)
The fix is based on the same strategy for handling namespace declarations as used by getAttributeNode. Note that this strategy makes these methods not return a DOMAttr for xmlns* attributes, but an instance of the (undocumented) class DOMNameSpaceNode. This is not really ideal, but at least this fix makes the behavior of getAttributeNode and getAttributeNodeNS consistent. A follow-up action would be to investigate whether DOMNameSpaceNode can be made into a subclass of DOMAttr (which may be hard due to the way libxml treats namespace declarations) or document this deviating return value for xmlns* attributes.
Diffstat (limited to 'Zend/zend_execute_API.c')
0 files changed, 0 insertions, 0 deletions