diff options
| author | Nikita Popov <nikita.ppv@gmail.com> | 2019-02-15 13:42:37 +0100 |
|---|---|---|
| committer | Nikita Popov <nikita.ppv@gmail.com> | 2019-02-15 14:43:37 +0100 |
| commit | e6e9bea25798068ff3c9135515e5d000fe70a43b (patch) | |
| tree | 1e56e3583c5bd959db6f568ab39a5edabe7ac774 /Zend/zend_inheritance.c | |
| parent | fae22461f95dfe8153fb74a53b9c5daeec47387f (diff) | |
| download | php-git-e6e9bea25798068ff3c9135515e5d000fe70a43b.tar.gz | |
Avoid uninitialized entries in properties_info_table
Also don't place it into xlat, there's only ever one user.
Diffstat (limited to 'Zend/zend_inheritance.c')
| -rw-r--r-- | Zend/zend_inheritance.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/Zend/zend_inheritance.c b/Zend/zend_inheritance.c index 2ce4df3049..67b8b849e4 100644 --- a/Zend/zend_inheritance.c +++ b/Zend/zend_inheritance.c @@ -855,19 +855,22 @@ static void do_inherit_class_constant(zend_string *name, zend_class_constant *pa void zend_build_properties_info_table(zend_class_entry *ce) { zend_property_info **table, *prop; + size_t size; if (ce->default_properties_count == 0) { return; } ZEND_ASSERT(ce->properties_info_table == NULL); + size = sizeof(zend_property_info *) * ce->default_properties_count; if (ce->type == ZEND_USER_CLASS) { - ce->properties_info_table = table = zend_arena_alloc(&CG(arena), - sizeof(zend_property_info *) * ce->default_properties_count); + ce->properties_info_table = table = zend_arena_alloc(&CG(arena), size); } else { - ce->properties_info_table = table = pemalloc( - sizeof(zend_property_info *) * ce->default_properties_count, 1); + ce->properties_info_table = table = pemalloc(size, 1); } + /* Dead slots may be left behind during inheritance. Make sure these are NULLed out. */ + memset(table, 0, size); + if (ce->parent && ce->parent->default_properties_count != 0) { zend_property_info **parent_table = ce->parent->properties_info_table; memcpy( |