summaryrefslogtreecommitdiff
path: root/Zend/zend_operators.c
diff options
context:
space:
mode:
authorSara Golemon <pollita@php.net>2017-07-22 21:23:29 -0400
committerSara Golemon <pollita@php.net>2017-07-22 21:23:29 -0400
commite23c132940a2463c0f7034a5443b58fe9e6c96cd (patch)
tree0507c41c18ec6bad2cb9a4e3285f59e473969065 /Zend/zend_operators.c
parent401188cbf986e3cbb0ae8d7b49f7ba31b79be9bd (diff)
parent1229b0f8cb483845e20d6687068a8c5edb79f5af (diff)
downloadphp-git-e23c132940a2463c0f7034a5443b58fe9e6c96cd.tar.gz
Merge branch 'PHP-7.1' into PHP-7.2
* PHP-7.1: Fix compile-time optimization of NAN comparisons
Diffstat (limited to 'Zend/zend_operators.c')
-rw-r--r--Zend/zend_operators.c20
1 files changed, 20 insertions, 0 deletions
diff --git a/Zend/zend_operators.c b/Zend/zend_operators.c
index ffc4dcc9a2..3574ea7065 100644
--- a/Zend/zend_operators.c
+++ b/Zend/zend_operators.c
@@ -2174,6 +2174,16 @@ ZEND_API int ZEND_FASTCALL is_not_equal_function(zval *result, zval *op1, zval *
ZEND_API int ZEND_FASTCALL is_smaller_function(zval *result, zval *op1, zval *op2) /* {{{ */
{
+ if (UNEXPECTED((Z_TYPE_P(op1) == IS_DOUBLE) && isnan(Z_DVAL_P(op1)))) {
+ ZVAL_FALSE(result);
+ return SUCCESS;
+ }
+
+ if (UNEXPECTED((Z_TYPE_P(op2) == IS_DOUBLE) && isnan(Z_DVAL_P(op2)))) {
+ ZVAL_FALSE(result);
+ return SUCCESS;
+ }
+
if (compare_function(result, op1, op2) == FAILURE) {
return FAILURE;
}
@@ -2184,6 +2194,16 @@ ZEND_API int ZEND_FASTCALL is_smaller_function(zval *result, zval *op1, zval *op
ZEND_API int ZEND_FASTCALL is_smaller_or_equal_function(zval *result, zval *op1, zval *op2) /* {{{ */
{
+ if (UNEXPECTED((Z_TYPE_P(op1) == IS_DOUBLE) && isnan(Z_DVAL_P(op1)))) {
+ ZVAL_FALSE(result);
+ return SUCCESS;
+ }
+
+ if (UNEXPECTED((Z_TYPE_P(op2) == IS_DOUBLE) && isnan(Z_DVAL_P(op2)))) {
+ ZVAL_FALSE(result);
+ return SUCCESS;
+ }
+
if (compare_function(result, op1, op2) == FAILURE) {
return FAILURE;
}