diff options
| author | George Peter Banyard <girgias@php.net> | 2020-09-16 02:03:46 +0200 |
|---|---|---|
| committer | George Peter Banyard <girgias@php.net> | 2020-09-21 14:32:00 +0100 |
| commit | e55f0c796c05bf3e52b77902a61b34f2241609af (patch) | |
| tree | ee50635e01bc5e1a6da96a5a0dfb45713edb26ea /ext/com_dotnet/com_iterator.c | |
| parent | 213b6667817b887e29f7fdf3a046c37c4462f756 (diff) | |
| download | php-git-e55f0c796c05bf3e52b77902a61b34f2241609af.tar.gz | |
Promote warnings to Error in COM extension
Closes GH-6141
Diffstat (limited to 'ext/com_dotnet/com_iterator.c')
| -rw-r--r-- | ext/com_dotnet/com_iterator.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/ext/com_dotnet/com_iterator.c b/ext/com_dotnet/com_iterator.c index 6126e958d5..66f885a905 100644 --- a/ext/com_dotnet/com_iterator.c +++ b/ext/com_dotnet/com_iterator.c @@ -149,6 +149,7 @@ zend_object_iterator *php_com_iter_get(zend_class_entry *ce, zval *object, int b obj = CDNO_FETCH(object); if (V_VT(&obj->v) != VT_DISPATCH && !V_ISARRAY(&obj->v)) { + /* TODO Promote to TypeError? */ php_error_docref(NULL, E_WARNING, "Variant is not an object or array VT=%d", V_VT(&obj->v)); return NULL; } @@ -172,6 +173,7 @@ zend_object_iterator *php_com_iter_get(zend_class_entry *ce, zval *object, int b dims = SafeArrayGetDim(V_ARRAY(&obj->v)); if (dims != 1) { + /* TODO Promote to ValueError? */ php_error_docref(NULL, E_WARNING, "Can only handle single dimension variant arrays (this array has %d)", dims); goto fail; |