summaryrefslogtreecommitdiff
path: root/ext/curl/interface.c
diff options
context:
space:
mode:
authorPierrick Charron <pierrick@php.net>2012-12-21 19:27:51 -0500
committerPierrick Charron <pierrick@php.net>2012-12-21 19:27:51 -0500
commite3c88d16b400cc4f69c5533239343bf14220ae2c (patch)
tree0e0d7c6e64fd84513c5b81c20be992d36cc94e45 /ext/curl/interface.c
parent52e7b0ce2cb9a8276a423920d7bf6f0f8bffd4df (diff)
parent5499c7d201ad22f551dfc370ae09132acf4f75ec (diff)
downloadphp-git-e3c88d16b400cc4f69c5533239343bf14220ae2c.tar.gz
Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4: Update NEWS file Fixed bug #63352 (Can't enable hostname validation when using curl stream wrappers) CURL >= 7.28.0 no longer support value 1 for CURLOPT_SSL_VERIFYHOST)
Diffstat (limited to 'ext/curl/interface.c')
-rw-r--r--ext/curl/interface.c10
1 files changed, 8 insertions, 2 deletions
diff --git a/ext/curl/interface.c b/ext/curl/interface.c
index 9e5d06bc16..8a8333dc5c 100644
--- a/ext/curl/interface.c
+++ b/ext/curl/interface.c
@@ -2015,8 +2015,14 @@ static int _php_curl_setopt(php_curl *ch, long option, zval **zvalue, zval *retu
switch (option) {
/* Long options */
case CURLOPT_SSL_VERIFYHOST:
- if(Z_TYPE_PP(zvalue)==IS_BOOL && Z_BVAL_PP(zvalue)) {
- php_error_docref(NULL TSRMLS_CC, E_NOTICE, "CURLOPT_SSL_VERIFYHOST set to true which disables common name validation (setting CURLOPT_SSL_VERIFYHOST to 2 enables common name validation)");
+ if(Z_BVAL_PP(zvalue) == 1) {
+#if LIBCURL_VERSION_NUM <= 0x071c00 /* 7.28.0 */
+ php_error_docref(NULL TSRMLS_CC, E_NOTICE, "CURLOPT_SSL_VERIFYHOST with value 1 is deprecated and will be removed as of libcurl 7.28.1. It is recommended to use value 2 instead");
+#else
+ php_error_docref(NULL TSRMLS_CC, E_NOTICE, "CURLOPT_SSL_VERIFYHOST no longer accepts the value 1, value 2 will be used instead");
+ error = curl_easy_setopt(ch->cp, option, 2);
+ break;
+#endif
}
case CURLOPT_AUTOREFERER:
case CURLOPT_BUFFERSIZE: