diff options
| author | Nikita Popov <nikita.ppv@gmail.com> | 2021-02-09 12:19:44 +0100 |
|---|---|---|
| committer | Nikita Popov <nikita.ppv@gmail.com> | 2021-02-09 12:19:44 +0100 |
| commit | ab92ffee227137ed38ebe2ca8ce26e70da6aa810 (patch) | |
| tree | 3ba0db8eccce1c1971883a03c1f6e95530225763 /ext/dom/document.c | |
| parent | ff8da0dcff2eb867a4de9e45ecb400d4abbf1f8e (diff) | |
| download | php-git-ab92ffee227137ed38ebe2ca8ce26e70da6aa810.tar.gz | |
Make getElementsByTagNameNS $namespace nullable
According to the DOM specification, this argument is supposed to
be nullable.
Diffstat (limited to 'ext/dom/document.c')
| -rw-r--r-- | ext/dom/document.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ext/dom/document.c b/ext/dom/document.c index c6d0f723f8..dbbabb8bff 100644 --- a/ext/dom/document.c +++ b/ext/dom/document.c @@ -986,7 +986,7 @@ PHP_METHOD(DOMDocument, getElementsByTagNameNS) xmlChar *local, *nsuri; id = ZEND_THIS; - if (zend_parse_parameters(ZEND_NUM_ARGS(), "ss", &uri, &uri_len, &name, &name_len) == FAILURE) { + if (zend_parse_parameters(ZEND_NUM_ARGS(), "s!s", &uri, &uri_len, &name, &name_len) == FAILURE) { RETURN_THROWS(); } @@ -995,7 +995,7 @@ PHP_METHOD(DOMDocument, getElementsByTagNameNS) php_dom_create_iterator(return_value, DOM_NODELIST); namednode = Z_DOMOBJ_P(return_value); local = xmlCharStrndup(name, name_len); - nsuri = xmlCharStrndup(uri, uri_len); + nsuri = xmlCharStrndup(uri ? uri : "", uri_len); dom_namednode_iter(intern, 0, namednode, NULL, local, nsuri); } /* }}} end dom_document_get_elements_by_tag_name_ns */ |