diff options
author | Nikita Popov <nikita.ppv@gmail.com> | 2019-12-20 11:24:03 +0100 |
---|---|---|
committer | Nikita Popov <nikita.ppv@gmail.com> | 2019-12-20 11:24:03 +0100 |
commit | d4ba1fd9631ff18b945ef3fb899601d5c1a22986 (patch) | |
tree | 1b716f346da002e670a898c41ec8c1ea2be2d812 /ext/fileinfo/libmagic | |
parent | 5155097431f1cf1705376dc85c5788bead61ccba (diff) | |
parent | c62cd9a43ad97aa279615b21f7cb5f1646f52d80 (diff) | |
download | php-git-d4ba1fd9631ff18b945ef3fb899601d5c1a22986.tar.gz |
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3:
Fix #74170: locale information change after mime_content_type
Diffstat (limited to 'ext/fileinfo/libmagic')
-rw-r--r-- | ext/fileinfo/libmagic/funcs.c | 5 | ||||
-rw-r--r-- | ext/fileinfo/libmagic/readcdf.c | 18 | ||||
-rw-r--r-- | ext/fileinfo/libmagic/softmagic.c | 14 |
3 files changed, 21 insertions, 16 deletions
diff --git a/ext/fileinfo/libmagic/funcs.c b/ext/fileinfo/libmagic/funcs.c index f9a9ab6c9b..db8877e0d5 100644 --- a/ext/fileinfo/libmagic/funcs.c +++ b/ext/fileinfo/libmagic/funcs.c @@ -527,11 +527,9 @@ file_replace(struct magic_set *ms, const char *pat, const char *rep) zend_string *repl; size_t rep_cnt = 0; - (void)setlocale(LC_CTYPE, "C"); - opts |= PCRE2_MULTILINE; convert_libmagic_pattern(&patt, (char*)pat, strlen(pat), opts); - if ((pce = pcre_get_compiled_regex_cache(Z_STR(patt))) == NULL) { + if ((pce = pcre_get_compiled_regex_cache_ex(Z_STR(patt), 0)) == NULL) { zval_ptr_dtor(&patt); rep_cnt = -1; goto out; @@ -553,7 +551,6 @@ file_replace(struct magic_set *ms, const char *pat, const char *rep) zend_string_release_ex(res, 0); out: - (void)setlocale(LC_CTYPE, ""); return rep_cnt; } diff --git a/ext/fileinfo/libmagic/readcdf.c b/ext/fileinfo/libmagic/readcdf.c index 5ee8d76e8a..be75e398cf 100644 --- a/ext/fileinfo/libmagic/readcdf.c +++ b/ext/fileinfo/libmagic/readcdf.c @@ -112,14 +112,24 @@ cdf_app_to_mime(const char *vbuf, const struct nv *nv) { size_t i; const char *rv = NULL; + char *vbuf_lower; - (void)setlocale(LC_CTYPE, "C"); - for (i = 0; nv[i].pattern != NULL; i++) - if (strcasestr(vbuf, nv[i].pattern) != NULL) { + vbuf_lower = zend_str_tolower_dup(vbuf, strlen(vbuf)); + for (i = 0; nv[i].pattern != NULL; i++) { + char *pattern_lower; + int found; + + pattern_lower = zend_str_tolower_dup(nv[i].pattern, strlen(nv[i].pattern)); + found = (strstr(vbuf_lower, pattern_lower) != NULL); + efree(pattern_lower); + + if (found) { rv = nv[i].mime; break; } - (void)setlocale(LC_CTYPE, ""); + } + + efree(vbuf_lower); return rv; } diff --git a/ext/fileinfo/libmagic/softmagic.c b/ext/fileinfo/libmagic/softmagic.c index 879a83b9a9..2b6d764291 100644 --- a/ext/fileinfo/libmagic/softmagic.c +++ b/ext/fileinfo/libmagic/softmagic.c @@ -469,27 +469,25 @@ flush: private int check_fmt(struct magic_set *ms, const char *fmt) { - pcre2_code *pce; - uint32_t capture_count; + pcre_cache_entry *pce; int rv = -1; zend_string *pattern; if (strchr(fmt, '%') == NULL) return 0; - (void)setlocale(LC_CTYPE, "C"); pattern = zend_string_init("~%[-0-9\\.]*s~", sizeof("~%[-0-9\\.]*s~") - 1, 0); - if ((pce = pcre_get_compiled_regex(pattern, &capture_count)) == NULL) { + if ((pce = pcre_get_compiled_regex_cache_ex(pattern, 0)) == NULL) { rv = -1; } else { - pcre2_match_data *match_data = php_pcre_create_match_data(capture_count, pce); + pcre2_code *re = php_pcre_pce_re(pce); + pcre2_match_data *match_data = php_pcre_create_match_data(0, re); if (match_data) { - rv = pcre2_match(pce, (PCRE2_SPTR)fmt, strlen(fmt), 0, 0, match_data, php_pcre_mctx()) > 0; + rv = pcre2_match(re, (PCRE2_SPTR)fmt, strlen(fmt), 0, 0, match_data, php_pcre_mctx()) > 0; php_pcre_free_match_data(match_data); } } - zend_string_release_ex(pattern, 0); - (void)setlocale(LC_CTYPE, ""); + zend_string_release(pattern); return rv; } |