diff options
| author | Peter Kokot <peterkokot@gmail.com> | 2018-10-15 04:31:31 +0200 |
|---|---|---|
| committer | Peter Kokot <peterkokot@gmail.com> | 2018-10-15 04:31:31 +0200 |
| commit | f1d7e3ca0b70f910fcecef0278de9c15440ca3c0 (patch) | |
| tree | 70af7290bf6c0b06f223254537b502013ade302e /ext/ftp | |
| parent | f98c916845571deeab189fb2ab52a17aef49edb8 (diff) | |
| download | php-git-f1d7e3ca0b70f910fcecef0278de9c15440ca3c0.tar.gz | |
Sync leading and final newlines in *.phpt sections
This patch adds missing newlines, trims multiple redundant final
newlines into a single one, and trims redundant leading newlines in all
*.phpt sections.
According to POSIX, a line is a sequence of zero or more non-' <newline>'
characters plus a terminating '<newline>' character. [1] Files should
normally have at least one final newline character.
C89 [2] and later standards [3] mention a final newline:
"A source file that is not empty shall end in a new-line character,
which shall not be immediately preceded by a backslash character."
Although it is not mandatory for all files to have a final newline
fixed, a more consistent and homogeneous approach brings less of commit
differences issues and a better development experience in certain text
editors and IDEs.
[1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
[2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2
[3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
Diffstat (limited to 'ext/ftp')
| -rw-r--r-- | ext/ftp/tests/ftp_alloc_basic1.phpt | 2 | ||||
| -rw-r--r-- | ext/ftp/tests/ftp_alloc_basic2.phpt | 2 | ||||
| -rw-r--r-- | ext/ftp/tests/ftp_exec_basic.phpt | 2 | ||||
| -rw-r--r-- | ext/ftp/tests/ftp_rawlist_basic2.phpt | 2 | ||||
| -rw-r--r-- | ext/ftp/tests/ftp_rmdir_basic.phpt | 2 | ||||
| -rw-r--r-- | ext/ftp/tests/ftp_ssl_connect_error.phpt | 1 |
6 files changed, 5 insertions, 6 deletions
diff --git a/ext/ftp/tests/ftp_alloc_basic1.phpt b/ext/ftp/tests/ftp_alloc_basic1.phpt index b2bdf7440d..c90f6e73fc 100644 --- a/ext/ftp/tests/ftp_alloc_basic1.phpt +++ b/ext/ftp/tests/ftp_alloc_basic1.phpt @@ -18,4 +18,4 @@ ftp_login($ftp, 'user', 'pass'); var_dump(ftp_alloc($ftp, 1024)); ?> --EXPECT-- -bool(true)
\ No newline at end of file +bool(true) diff --git a/ext/ftp/tests/ftp_alloc_basic2.phpt b/ext/ftp/tests/ftp_alloc_basic2.phpt index b9e4253fe8..41911e3396 100644 --- a/ext/ftp/tests/ftp_alloc_basic2.phpt +++ b/ext/ftp/tests/ftp_alloc_basic2.phpt @@ -20,4 +20,4 @@ var_dump($result); ?> --EXPECT-- bool(true) -string(20) "1024 bytes allocated"
\ No newline at end of file +string(20) "1024 bytes allocated" diff --git a/ext/ftp/tests/ftp_exec_basic.phpt b/ext/ftp/tests/ftp_exec_basic.phpt index 4a1f63e388..dbf7ce331f 100644 --- a/ext/ftp/tests/ftp_exec_basic.phpt +++ b/ext/ftp/tests/ftp_exec_basic.phpt @@ -18,4 +18,4 @@ if (!$ftp) die("Couldn't connect to the server"); var_dump(ftp_exec($ftp, 'ls -al')); ?> --EXPECT-- -bool(true)
\ No newline at end of file +bool(true) diff --git a/ext/ftp/tests/ftp_rawlist_basic2.phpt b/ext/ftp/tests/ftp_rawlist_basic2.phpt index 1d93643429..9ea9bd2865 100644 --- a/ext/ftp/tests/ftp_rawlist_basic2.phpt +++ b/ext/ftp/tests/ftp_rawlist_basic2.phpt @@ -18,4 +18,4 @@ if (!$ftp) die("Couldn't connect to the server"); var_dump(ftp_rawlist($ftp, 'no_exists/')); ?> --EXPECT-- -bool(false)
\ No newline at end of file +bool(false) diff --git a/ext/ftp/tests/ftp_rmdir_basic.phpt b/ext/ftp/tests/ftp_rmdir_basic.phpt index 6626cb4bed..84063db05f 100644 --- a/ext/ftp/tests/ftp_rmdir_basic.phpt +++ b/ext/ftp/tests/ftp_rmdir_basic.phpt @@ -18,4 +18,4 @@ ftp_login($ftp, 'user', 'pass'); var_dump(ftp_rmdir($ftp, 'www/')); ?> --EXPECT-- -bool(true)
\ No newline at end of file +bool(true) diff --git a/ext/ftp/tests/ftp_ssl_connect_error.phpt b/ext/ftp/tests/ftp_ssl_connect_error.phpt index 6deec03e5e..59eda36afe 100644 --- a/ext/ftp/tests/ftp_ssl_connect_error.phpt +++ b/ext/ftp/tests/ftp_ssl_connect_error.phpt @@ -24,7 +24,6 @@ echo "\n-- Testing ftp_ssl_connect() function timeout warning for value 0 --\n"; ftp_ssl_connect('totes.invalid', 21, 0); echo "===DONE===\n"; - --EXPECTF-- *** Testing ftp_ssl_connect() function : error conditions *** |