diff options
| author | Christoph M. Becker <cmbecker69@gmx.de> | 2020-06-16 16:29:05 +0200 |
|---|---|---|
| committer | Christoph M. Becker <cmbecker69@gmx.de> | 2020-06-16 18:39:09 +0200 |
| commit | 92c4b0651368a4135f692af48f4716c96de4bd92 (patch) | |
| tree | 052276ba1af9bcf5fd113f9bf8d6d93075d69aa3 /ext/gd | |
| parent | 9ff3230c20f27ac35788aca72f16ff928a25f81b (diff) | |
| download | php-git-92c4b0651368a4135f692af48f4716c96de4bd92.tar.gz | |
Use ZEND_UNREACHABLE() instead of ZEND_ASSERT(0)
Instead of marking unreachable code with `ZEND_ASSERT(0)`, we introduce
`ZEND_UNREACHABLE()`, so that MSVC which does not consider `assert(0)`
to mark unreachable code does no longer trigger C4715[1] warnings in
debug builds. This may be useful for other compilers as well.
[1] <https://docs.microsoft.com/de-de/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4715?view=vs-2019>
Diffstat (limited to 'ext/gd')
| -rw-r--r-- | ext/gd/gd.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/ext/gd/gd.c b/ext/gd/gd.c index 4089e40691..d915398c7b 100644 --- a/ext/gd/gd.c +++ b/ext/gd/gd.c @@ -1872,7 +1872,7 @@ static void _php_image_output(INTERNAL_FUNCTION_PARAMETERS, int image_type, char (*func_p)(im, fp, q, t); break; default: - ZEND_ASSERT(0); + ZEND_UNREACHABLE(); } fflush(fp); fclose(fp); @@ -1899,7 +1899,7 @@ static void _php_image_output(INTERNAL_FUNCTION_PARAMETERS, int image_type, char (*func_p)(im, tmp, q, t); break; default: - ZEND_ASSERT(0); + ZEND_UNREACHABLE(); } fseek(tmp, 0, SEEK_SET); |