summaryrefslogtreecommitdiff
path: root/ext/intl/breakiterator/breakiterator_methods.cpp
diff options
context:
space:
mode:
authorNikita Popov <nikita.ppv@gmail.com>2019-07-18 17:02:29 +0200
committerNikita Popov <nikita.ppv@gmail.com>2019-10-30 13:03:45 +0100
commit5cbe5a538c92d7d515b0270625e2f705a1c02b18 (patch)
tree564ca30e0a10d2b5966ccda7384df55a1faf715c /ext/intl/breakiterator/breakiterator_methods.cpp
parentf9ab339c0f491f16e915262401a7c6cfcffa2150 (diff)
downloadphp-git-5cbe5a538c92d7d515b0270625e2f705a1c02b18.tar.gz
Don't use chunking for stream writes
We're currently splitting up large writes into 8K size chunks, which adversely affects I/O performance in some cases. Splitting up writes doesn't make a lot of sense, as we already must have a backing buffer, so there is no memory/performance tradeoff to be made here. This change disables the write chunking at the stream layer, but retains the current retry loop for partial writes. In particular network writes will typically only write part of the data for large writes, so we need to keep the retry loop to preserve backwards compatibility. If issues due to this change turn up, chunking should be reintroduced at lower levels where it is needed to avoid issues for specific streams, rather than unnecessarily enforcing it for all streams.
Diffstat (limited to 'ext/intl/breakiterator/breakiterator_methods.cpp')
0 files changed, 0 insertions, 0 deletions