summaryrefslogtreecommitdiff
path: root/ext/json/json.c
diff options
context:
space:
mode:
authorXinchen Hui <laruence@gmail.com>2016-01-22 11:22:37 +0800
committerXinchen Hui <laruence@gmail.com>2016-01-22 11:22:37 +0800
commit9b61479166d8fa05f2fc2668d317cf21bd37354b (patch)
tree963491384979d88cf88084f2adc01de28429d751 /ext/json/json.c
parentaf255c67ebe4bdd0b990ab23310969817d05188d (diff)
downloadphp-git-9b61479166d8fa05f2fc2668d317cf21bd37354b.tar.gz
We don't need to dup zend_class_constant here.
quote why the internal class is still using duplication: ``` for internal classes, the zend_class_constant is malloc-ed. we need to free it. if (const->ce == ce) { zval_ptr_dtor(&const->value); free(const) } so, if two classes share one const, and it(parent class) was freed before, this read(in child class, const->ce) is invalid.. and destroy_zend_class is called via zend_hash_destroy(class_table). which is not in reverse order... so, parent classes are dtor first. if we want this work, we should change that order. ```
Diffstat (limited to 'ext/json/json.c')
0 files changed, 0 insertions, 0 deletions