diff options
| author | Nikita Popov <nikita.ppv@gmail.com> | 2020-01-20 10:34:17 +0100 |
|---|---|---|
| committer | Nikita Popov <nikita.ppv@gmail.com> | 2020-01-20 10:34:17 +0100 |
| commit | 68112224221d47169c69ea353beeb73c58ebbe3a (patch) | |
| tree | 6df6967fd6e3641706b14146f741c771e258ca21 /ext/oci8 | |
| parent | 5947437d47cc3bf8f289e52e6361fccad4b08ae3 (diff) | |
| download | php-git-68112224221d47169c69ea353beeb73c58ebbe3a.tar.gz | |
Eliminate uses of ZVAL_ZVAL and friends
Instead add RETURN_COPY(_VALUE) macros will the expected behavior.
RETURN_ZVAL doesn't make any sense since PHP 7, but has stuck
around, probably because the alternative was to write directly to
the return_value variable.
Diffstat (limited to 'ext/oci8')
| -rw-r--r-- | ext/oci8/oci8_interface.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/ext/oci8/oci8_interface.c b/ext/oci8/oci8_interface.c index b48294e3a5..299788cab6 100644 --- a/ext/oci8/oci8_interface.c +++ b/ext/oci8/oci8_interface.c @@ -2382,11 +2382,9 @@ PHP_FUNCTION(oci_collection_element_get) PHP_OCI_ZVAL_TO_COLLECTION(tmp, collection); - if (php_oci_collection_element_get(collection, element_index, &value)) { + if (php_oci_collection_element_get(collection, element_index, return_value)) { RETURN_FALSE; } - - RETURN_ZVAL(&value, 1, 1); } /* }}} */ |