summaryrefslogtreecommitdiff
path: root/ext/pdo_mysql/mysql_driver.c
diff options
context:
space:
mode:
authorGeorge Peter Banyard <girgias@php.net>2020-12-23 14:15:56 +0100
committerGeorge Peter Banyard <girgias@php.net>2021-01-06 10:20:59 +0000
commit43f69160cfac8e33969e059eeab756a223be4480 (patch)
treecfefbb5e91f4632023658f5d9721e962c83175de /ext/pdo_mysql/mysql_driver.c
parentd04adf60bee30a167845644c3d480583ca755420 (diff)
downloadphp-git-43f69160cfac8e33969e059eeab756a223be4480.tar.gz
Boolify PDO's set_attribute driver function
Diffstat (limited to 'ext/pdo_mysql/mysql_driver.c')
-rw-r--r--ext/pdo_mysql/mysql_driver.c18
1 files changed, 9 insertions, 9 deletions
diff --git a/ext/pdo_mysql/mysql_driver.c b/ext/pdo_mysql/mysql_driver.c
index 54fa43700d..ce40a21cd0 100644
--- a/ext/pdo_mysql/mysql_driver.c
+++ b/ext/pdo_mysql/mysql_driver.c
@@ -390,7 +390,7 @@ static inline int mysql_handle_autocommit(pdo_dbh_t *dbh)
/* }}} */
/* {{{ pdo_mysql_set_attribute */
-static int pdo_mysql_set_attribute(pdo_dbh_t *dbh, zend_long attr, zval *val)
+static bool pdo_mysql_set_attribute(pdo_dbh_t *dbh, zend_long attr, zval *val)
{
zend_long lval = zval_get_long(val);
zend_bool bval = lval ? 1 : 0;
@@ -403,29 +403,29 @@ static int pdo_mysql_set_attribute(pdo_dbh_t *dbh, zend_long attr, zval *val)
if (dbh->auto_commit ^ bval) {
dbh->auto_commit = bval;
if (!mysql_handle_autocommit(dbh)) {
- PDO_DBG_RETURN(0);
+ PDO_DBG_RETURN(false);
}
}
- PDO_DBG_RETURN(1);
+ PDO_DBG_RETURN(true);
case PDO_ATTR_DEFAULT_STR_PARAM:
((pdo_mysql_db_handle *)dbh->driver_data)->assume_national_character_set_strings = lval == PDO_PARAM_STR_NATL;
- PDO_DBG_RETURN(1);
+ PDO_DBG_RETURN(true);
case PDO_MYSQL_ATTR_USE_BUFFERED_QUERY:
/* ignore if the new value equals the old one */
((pdo_mysql_db_handle *)dbh->driver_data)->buffered = bval;
- PDO_DBG_RETURN(1);
+ PDO_DBG_RETURN(true);
case PDO_MYSQL_ATTR_DIRECT_QUERY:
case PDO_ATTR_EMULATE_PREPARES:
/* ignore if the new value equals the old one */
((pdo_mysql_db_handle *)dbh->driver_data)->emulate_prepare = bval;
- PDO_DBG_RETURN(1);
+ PDO_DBG_RETURN(true);
case PDO_ATTR_FETCH_TABLE_NAMES:
((pdo_mysql_db_handle *)dbh->driver_data)->fetch_table_names = bval;
- PDO_DBG_RETURN(1);
+ PDO_DBG_RETURN(true);
#ifndef PDO_USE_MYSQLND
case PDO_MYSQL_ATTR_MAX_BUFFER_SIZE:
@@ -436,12 +436,12 @@ static int pdo_mysql_set_attribute(pdo_dbh_t *dbh, zend_long attr, zval *val)
} else {
((pdo_mysql_db_handle *)dbh->driver_data)->max_buffer_size = lval;
}
- PDO_DBG_RETURN(1);
+ PDO_DBG_RETURN(true);
break;
#endif
default:
- PDO_DBG_RETURN(0);
+ PDO_DBG_RETURN(false);
}
}
/* }}} */