diff options
| author | George Peter Banyard <girgias@php.net> | 2020-12-23 02:17:46 +0100 |
|---|---|---|
| committer | George Peter Banyard <girgias@php.net> | 2021-01-06 10:20:57 +0000 |
| commit | d04adf60bee30a167845644c3d480583ca755420 (patch) | |
| tree | 531f72ea2f7b6b5a1db76431b2bd6eef9d89268b /ext/pdo_sqlite/sqlite_driver.c | |
| parent | 6728c1bd72f2ddb46528a0c61ac833b1036a12a2 (diff) | |
| download | php-git-d04adf60bee30a167845644c3d480583ca755420.tar.gz | |
Boolify PDO's transaction handlers
This includes begin(), commit(), rollBack(), and inTransaction()
Diffstat (limited to 'ext/pdo_sqlite/sqlite_driver.c')
| -rw-r--r-- | ext/pdo_sqlite/sqlite_driver.c | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/ext/pdo_sqlite/sqlite_driver.c b/ext/pdo_sqlite/sqlite_driver.c index fcf82c62bf..a7c9284dfc 100644 --- a/ext/pdo_sqlite/sqlite_driver.c +++ b/ext/pdo_sqlite/sqlite_driver.c @@ -238,7 +238,7 @@ static int sqlite_handle_quoter(pdo_dbh_t *dbh, const char *unquoted, size_t unq return 1; } -static int sqlite_handle_begin(pdo_dbh_t *dbh) +static bool sqlite_handle_begin(pdo_dbh_t *dbh) { pdo_sqlite_db_handle *H = (pdo_sqlite_db_handle *)dbh->driver_data; char *errmsg = NULL; @@ -247,12 +247,12 @@ static int sqlite_handle_begin(pdo_dbh_t *dbh) pdo_sqlite_error(dbh); if (errmsg) sqlite3_free(errmsg); - return 0; + return false; } - return 1; + return true; } -static int sqlite_handle_commit(pdo_dbh_t *dbh) +static bool sqlite_handle_commit(pdo_dbh_t *dbh) { pdo_sqlite_db_handle *H = (pdo_sqlite_db_handle *)dbh->driver_data; char *errmsg = NULL; @@ -261,12 +261,12 @@ static int sqlite_handle_commit(pdo_dbh_t *dbh) pdo_sqlite_error(dbh); if (errmsg) sqlite3_free(errmsg); - return 0; + return false; } - return 1; + return true; } -static int sqlite_handle_rollback(pdo_dbh_t *dbh) +static bool sqlite_handle_rollback(pdo_dbh_t *dbh) { pdo_sqlite_db_handle *H = (pdo_sqlite_db_handle *)dbh->driver_data; char *errmsg = NULL; @@ -275,9 +275,9 @@ static int sqlite_handle_rollback(pdo_dbh_t *dbh) pdo_sqlite_error(dbh); if (errmsg) sqlite3_free(errmsg); - return 0; + return false; } - return 1; + return true; } static int pdo_sqlite_get_attribute(pdo_dbh_t *dbh, zend_long attr, zval *return_value) @@ -729,7 +729,7 @@ static const struct pdo_dbh_methods sqlite_methods = { NULL, /* check_liveness: not needed */ get_driver_methods, pdo_sqlite_request_shutdown, - NULL, /* in_transaction */ + NULL, /* in transaction, use PDO's internal tracking mechanism */ pdo_sqlite_get_gc }; |