diff options
author | Tyson Andre <tysonandre775@hotmail.com> | 2020-09-06 16:47:34 -0400 |
---|---|---|
committer | Tyson Andre <tysonandre775@hotmail.com> | 2020-09-10 09:33:46 -0400 |
commit | 09904242af6b3d9bcc1c1c8c21cb81d128382b3f (patch) | |
tree | c9ff0a62822017fbed506101a734007b66bd9415 /ext/reflection/php_reflection.c | |
parent | 87104292837666f5ed8c4a6019ee8c9e1c7f7869 (diff) | |
download | php-git-09904242af6b3d9bcc1c1c8c21cb81d128382b3f.tar.gz |
Avoid gap in AST_CLASS child nodes for attributes
See https://github.com/nikic/php-ast/pull/181
> Hm, I'm thinking it would make more sense to change the structure in php-src.
> All the function types have consistent AST structure, but there's no reason at
> all why classes should be consistent with functions.
It's unusual to have an unused child node between other child nodes that are
used (for name, extends, implements, and attributes of AST_CLASS)
> That gap is a leftover from a previous refactoring. An earlier version of
> attributes extended `zend_ast_decl` with a new member called `attributes` and
> therefore did not need to handle functions and classes in different ways.
Closes GH-6088
Diffstat (limited to 'ext/reflection/php_reflection.c')
0 files changed, 0 insertions, 0 deletions