summaryrefslogtreecommitdiff
path: root/ext/session/session.c
diff options
context:
space:
mode:
authorChristoph M. Becker <cmbecker69@gmx.de>2020-03-31 08:39:34 +0200
committerChristoph M. Becker <cmbecker69@gmx.de>2020-03-31 08:39:54 +0200
commitd533fa15e609d894516cb0091b7cdb57667bde1f (patch)
tree3b05eddece3a470b682d92826e2c53964306ca64 /ext/session/session.c
parentb9b49cfb7b88e0d95d91ea82b75b2b19ca88331a (diff)
parentb510250b8ebe9d90b1db150d7a1edc75893f2e48 (diff)
downloadphp-git-d533fa15e609d894516cb0091b7cdb57667bde1f.tar.gz
Merge branch 'PHP-7.3' into PHP-7.4
* PHP-7.3: Fix #79413: session_create_id() fails for active sessions
Diffstat (limited to 'ext/session/session.c')
-rw-r--r--ext/session/session.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/ext/session/session.c b/ext/session/session.c
index 092dea81ce..1efe220c77 100644
--- a/ext/session/session.c
+++ b/ext/session/session.c
@@ -2232,7 +2232,7 @@ static PHP_FUNCTION(session_regenerate_id)
RETURN_FALSE;
}
if (PS(use_strict_mode) && PS(mod)->s_validate_sid &&
- PS(mod)->s_validate_sid(&PS(mod_data), PS(id)) == FAILURE) {
+ PS(mod)->s_validate_sid(&PS(mod_data), PS(id)) == SUCCESS) {
zend_string_release_ex(PS(id), 0);
PS(id) = PS(mod)->s_create_sid(&PS(mod_data));
if (!PS(id)) {
@@ -2294,7 +2294,7 @@ static PHP_FUNCTION(session_create_id)
break;
} else {
/* Detect collision and retry */
- if (PS(mod)->s_validate_sid(&PS(mod_data), new_id) == FAILURE) {
+ if (PS(mod)->s_validate_sid(&PS(mod_data), new_id) == SUCCESS) {
zend_string_release_ex(new_id, 0);
new_id = NULL;
continue;