diff options
author | Dmitry Stogov <dmitry@zend.com> | 2018-06-01 11:58:57 +0300 |
---|---|---|
committer | Dmitry Stogov <dmitry@zend.com> | 2018-06-01 11:58:57 +0300 |
commit | 0b90cf85a6ace22abd0f9f86d5015a5b6db92387 (patch) | |
tree | e01be0712ad1d7dbcd61c81ce03b9544a69e4972 /ext/soap/php_sdl.c | |
parent | 9e0f131d2b0e8bf98859c12104a7b0cd8951c135 (diff) | |
download | php-git-0b90cf85a6ace22abd0f9f86d5015a5b6db92387.tar.gz |
Removed "dead" code (zend_hash_update() never fails)
Diffstat (limited to 'ext/soap/php_sdl.c')
-rw-r--r-- | ext/soap/php_sdl.c | 18 |
1 files changed, 6 insertions, 12 deletions
diff --git a/ext/soap/php_sdl.c b/ext/soap/php_sdl.c index 05df5e7e0c..440c4a7448 100644 --- a/ext/soap/php_sdl.c +++ b/ext/soap/php_sdl.c @@ -3360,18 +3360,12 @@ cache_in_memory: p.time = t; p.sdl = psdl; - if (NULL != zend_hash_str_update_mem(SOAP_GLOBAL(mem_cache), uri, - uri_len, &p, sizeof(sdl_cache_bucket))) { - /* remove non-persitent sdl structure */ - delete_sdl_impl(sdl); - /* and replace it with persistent one */ - sdl = psdl; - } else { - php_error_docref(NULL, E_WARNING, "Failed to register persistent entry"); - /* clean up persistent sdl */ - delete_psdl_int(&p); - /* keep non-persistent sdl and return it */ - } + zend_hash_str_update_mem(SOAP_GLOBAL(mem_cache), uri, + uri_len, &p, sizeof(sdl_cache_bucket)); + /* remove non-persitent sdl structure */ + delete_sdl_impl(sdl); + /* and replace it with persistent one */ + sdl = psdl; } } |