diff options
author | Dmitry Stogov <dmitry@zend.com> | 2019-10-07 17:57:49 +0300 |
---|---|---|
committer | Dmitry Stogov <dmitry@zend.com> | 2019-10-07 17:57:49 +0300 |
commit | b02b81299ccef7de244bac7ffc605e3d2943fa88 (patch) | |
tree | f07036f89b7f4c8f3162f20702881061d59a13a3 /ext/standard/array.c | |
parent | e2100619ac064fdd4e7fe79e296a2ca087409e7d (diff) | |
download | php-git-b02b81299ccef7de244bac7ffc605e3d2943fa88.tar.gz |
Comparison cleanup:
- introduce zend_compare() that returns -1,0,1 dirctly (without intermediate zval)
- remove compare_objects() object handler, and keep only compare() handler
Diffstat (limited to 'ext/standard/array.c')
-rw-r--r-- | ext/standard/array.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/ext/standard/array.c b/ext/standard/array.c index c8c58413f0..3b827e519c 100644 --- a/ext/standard/array.c +++ b/ext/standard/array.c @@ -363,7 +363,6 @@ static int php_array_data_compare(const void *a, const void *b) /* {{{ */ { Bucket *f; Bucket *s; - zval result; zval *first; zval *second; @@ -379,12 +378,7 @@ static int php_array_data_compare(const void *a, const void *b) /* {{{ */ if (UNEXPECTED(Z_TYPE_P(second) == IS_INDIRECT)) { second = Z_INDIRECT_P(second); } - if (compare_function(&result, first, second) == FAILURE) { - return 0; - } - - ZEND_ASSERT(Z_TYPE(result) == IS_LONG); - return ZEND_NORMALIZE_BOOL(Z_LVAL(result)); + return zend_compare(first, second); } /* }}} */ |