diff options
| author | Peter Kokot <peterkokot@gmail.com> | 2018-09-16 01:14:08 +0200 |
|---|---|---|
| committer | Peter Kokot <peterkokot@gmail.com> | 2018-09-18 05:32:08 +0200 |
| commit | d3ca28f5694e7848fb2b238bbe3e9564230ae65e (patch) | |
| tree | 60bef3e2097c17b370ddc8eaee424416bbd39399 /ext/standard/basic_functions.c | |
| parent | cfe46a5d7970e988591f0593ae3ebddf9e5196f4 (diff) | |
| download | php-git-d3ca28f5694e7848fb2b238bbe3e9564230ae65e.tar.gz | |
Remove HAVE_STRING_H
The C89 standard and later defines the `<string.h>` header as part of
the standard headers [1] and on current systems it is always present.
Code included also `<strings.h>` header as an alterinative in some
files. This kind of check was relevant on some older systems where the
`<strings.h>` file included definitions for the C89 compliant
`<string.h>`. Today such alternative check is not required anymore. The
`<strings.h>` file is part of the POSIX definition these days.
Also Autoconf suggests doing this and relying on C89 or above [2] and [3].
This patch also cleans few unused `<strings.h>` inclusions in the libmbfl.
[1]: https://port70.net/~nsz/c/c89/c89-draft.html#4.1.2
[2]: http://git.savannah.gnu.org/cgit/autoconf.git/tree/lib/autoconf/headers.m4
[3]: https://www.gnu.org/software/autoconf/manual/autoconf-2.69/autoconf.html
Diffstat (limited to 'ext/standard/basic_functions.c')
| -rw-r--r-- | ext/standard/basic_functions.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/ext/standard/basic_functions.c b/ext/standard/basic_functions.c index 160e510831..f60c09b5e4 100644 --- a/ext/standard/basic_functions.c +++ b/ext/standard/basic_functions.c @@ -75,11 +75,7 @@ typedef struct yy_buffer_state *YY_BUFFER_STATE; # include <unistd.h> #endif -#if HAVE_STRING_H -# include <string.h> -#else -# include <strings.h> -#endif +#include <string.h> #if HAVE_LOCALE_H # include <locale.h> |